Change spacer minimum height hint #1511
Conversation
|
Doesn't completely work. This worked on Linux, but did not work on my hi-res windows VM. The icons to the left are actually a vertical toolbar. The spacing between the main section or the toolbar needs to be whichever is more limiting. I will have to look into this a little closer. |
jamescowens
force-pushed
the
fixunlockbuttondisappear
branch
from
bf2232d to
63ed361
Compare
This hopefully fixes the lock fall of the page issue (again).
jamescowens
force-pushed
the
fixunlockbuttondisappear
branch
from
63ed361 to
6cfbe30
Compare
|
Looks like the latest try works. The code in bitcoingui.cpp that was attempting to put another spacer after the lock button on the vertical toolbar doesn't work. It just so happened to be apparently working by chance. The toolbar length by definition does NOT control the contraction limit (minimum size) of the window. In fact the Qt documentation states that the toolbar icons are designed to disappear if the window the toolbar is docked to contracts beyond the limit where all the icons can be shown. If the toolbar is attached to the main window, it is supposed to show an arrow to be able to access the icons that have been suppressed, but that does not seem to be working, and we don't want this for something as important as the lock icon anyway. The only thing that works is to increase the minimum size of the spacers in overviewpage.ui to ensure that the minimum size of the window does not cause the lock icon to drop out. I think I have picked values that work in all circumstances, but because of the wide variance of type sizes, etc. for different DPI displays, there may be a corner case where this is not true. |
|
This is a relatively trivial change and we should merge to staging. It will not require any regression testing, beyond the sanity check to ensure it is working correctly for the impending release. (@barton2526). |
jamescowens
requested review from
denravonska and
cyrossignol
and removed request for
cyrossignol
Added: - Add freedesktop.org desktop file and icon set #1438 (@a123b) - Add warning in help for blockchain scan for importprivkey #1469 (@jamescowens) - Consolidateunspent rpc function #1472 (@jamescowens) - Scraper 2.0 improvements #1481, #1488, #1509, and #1514 (@jamescowens, @cyrossignol) - explorer mode operation - simplified explainmagnitude output - improved convergence reporting, including scraper information in the tooltip when fDebug3 is set - improved statistics and SB contract core caching based on a bClean flag in the cache global - new SB format and packing for bv11 - new SB contract hashing (native) for bv11 - changes to accomodate new beacon approach - Implement in memory versioning for team file ETags - Implement local dynamic team requirement removal and whitelist #1502 (@cyrossignol) Changed: - Quiet logging for getmininginfo and scraper INFO logging level #1460 (@jamescowens) - Spelling corrections #1461, #1462 (@caraka) - Update crypto module #1453 (@denravonska) - Update .travis.yml for Bionic #1475 (@jamescowens) - Create CPID classes and clean up CPID code #1477 (@cyrossignol) - Refactor researcher context and CPID harvesting #1480 (@cyrossignol) - Remove boinckey export RPC method and import handler - Notify when wallet locked in advertisebeacon RPC method #1504 (@cyrossignol) - Notify when wallet locked in beaconstatus RPC method #1506 (@cyrossignol) - Change spacer minimum height hint #1511 (@jamescowens) Removed: - Remove safe mode #1434 (@denravonska) - Remove bitcoin.moc in Makefile.qt.include #1444 (@RoboticMind) - Clean up legacy Proof-of-Work functions #1497 (@cyrossignol) Fixed: - Constrain walletpassphrase to 10000000 seconds #1459 (@jamescowens) - Straighten out localization in the scraper. #1471 (@jamescowens) - Quick fix for rainbymagnitude #1473 (@jamescowens) - Correct negation error in scraper tooltip for vScrapersNotPublishing #1484 (@jamescowens) - Fix staked block rejection when active researcher #1485 (@cyrossignol) - Add back informational magnitude to generated blocks #1489 (@cyrossignol) - Add back in the in sync check in ScraperGetNeuralContract #1492 (@jamescowens) - Scraper correct team file processing. #1501 (@jamescowens) - Have importwallet file path default to datadir #1508 (@jamescowens) - Scraper add Beacon Map size check to ensure convergence #1515 (@jamescowens)
This changes the minimum height hint of the spacer between
the Status fields and the Poll and Error fields. This seems to
fix the Lock Wallet button disappearing when the window is resized
to the minimum.