[WIP] integrated_scraper_2 changes tracking #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done with a atomic boolean that is updated by the scraper or neuralnet loops as a result of the call to the OutOfSyncByAge function.
|
Should we change this to put the atomic boolean update in the OutOfSyncByAge function itself? That way the only code that will be calling this is in main.cpp or the scraper/neuralnet loops in the scraper, and all other threads in the wallet can simply check the boolean without a lock on cs_main? |
|
The reason this is necessary is that the GridcoinServices() part in main is protected by it's own out of sync check; however, the neural_net message function calls in ProcessMessage are not. |
jamescowens
force-pushed
the
integrated_scraper_2
branch
3 times, most recently
from
3506d76 to
51058b9
Compare
jamescowens
force-pushed
the
integrated_scraper_2
branch
from
51058b9 to
c2e9b15
Compare
jamescowens
force-pushed
the
integrated_scraper_2
branch
from
3fe53ff to
32abe1e
Compare
Compact integer superblock
Optimize NN::Cpid less than and greater than operators
denravonska
reviewed
Jul 6, 2019
denravonska
reviewed
Jul 6, 2019
denravonska
reviewed
Jul 6, 2019
denravonska
reviewed
Jul 6, 2019
|
utACK once my comments are straightened out. |
jamescowens
changed the title
jamescowens
requested review from
cyrossignol
and removed request for
cyrossignol
Expand Superblock class functionality and remove project-level CPID data
This implements NN functions callable by the ProcessMessage in main and also implements necessary scraper functions as well as extending the ConvergedScraperStats struct for the new Superblock class.
cyrossignol
reviewed
Jul 15, 2019
jamescowens
force-pushed
the
integrated_scraper_2
branch
from
d433114 to
87c24ea
Compare
Provide for keying std::unordered_map with NN::QuorumHash objects
Implement string parsing for NN::QuorumHash
This was referenced Jul 22, 2019
to pipe from comma
denravonska
reviewed
Jul 27, 2019
denravonska
approved these changes
Jul 27, 2019
jamescowens
added a commit
that referenced
this pull request
Aug 20, 2019
Added: - Add freedesktop.org desktop file and icon set #1438 (@a123b) - Add warning in help for blockchain scan for importprivkey #1469 (@jamescowens) - Consolidateunspent rpc function #1472 (@jamescowens) - Scraper 2.0 improvements #1481, #1488, #1509, and #1514 (@jamescowens, @cyrossignol) - explorer mode operation - simplified explainmagnitude output - improved convergence reporting, including scraper information in the tooltip when fDebug3 is set - improved statistics and SB contract core caching based on a bClean flag in the cache global - new SB format and packing for bv11 - new SB contract hashing (native) for bv11 - changes to accomodate new beacon approach - Implement in memory versioning for team file ETags - Implement local dynamic team requirement removal and whitelist #1502 (@cyrossignol) Changed: - Quiet logging for getmininginfo and scraper INFO logging level #1460 (@jamescowens) - Spelling corrections #1461, #1462 (@caraka) - Update crypto module #1453 (@denravonska) - Update .travis.yml for Bionic #1475 (@jamescowens) - Create CPID classes and clean up CPID code #1477 (@cyrossignol) - Refactor researcher context and CPID harvesting #1480 (@cyrossignol) - Remove boinckey export RPC method and import handler - Notify when wallet locked in advertisebeacon RPC method #1504 (@cyrossignol) - Notify when wallet locked in beaconstatus RPC method #1506 (@cyrossignol) - Change spacer minimum height hint #1511 (@jamescowens) Removed: - Remove safe mode #1434 (@denravonska) - Remove bitcoin.moc in Makefile.qt.include #1444 (@RoboticMind) - Clean up legacy Proof-of-Work functions #1497 (@cyrossignol) Fixed: - Constrain walletpassphrase to 10000000 seconds #1459 (@jamescowens) - Straighten out localization in the scraper. #1471 (@jamescowens) - Quick fix for rainbymagnitude #1473 (@jamescowens) - Correct negation error in scraper tooltip for vScrapersNotPublishing #1484 (@jamescowens) - Fix staked block rejection when active researcher #1485 (@cyrossignol) - Add back informational magnitude to generated blocks #1489 (@cyrossignol) - Add back in the in sync check in ScraperGetNeuralContract #1492 (@jamescowens) - Scraper correct team file processing. #1501 (@jamescowens) - Have importwallet file path default to datadir #1508 (@jamescowens) - Scraper add Beacon Map size check to ensure convergence #1515 (@jamescowens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done with a atomic boolean that is updated by the
scraper or neuralnet loops as a result of the call to the
OutOfSyncByAge function.