-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"do run gapic" failed #651
Comments
ben-clayton
added a commit
to ben-clayton/gapid
that referenced
this issue
Jun 29, 2017
Should be UTF8. Fixes: google#651
RenfengLiu
pushed a commit
to RenfengLiu/gapid
that referenced
this issue
Apr 23, 2020
…ismatch Fix interface mismatch between VS and GS in deferredshadows
purvisa-at-google-com
pushed a commit
that referenced
this issue
Sep 29, 2022
…651) PR will add the capability of compression with CGo that would slow the builds. Therefore similar to ASTC, ETC should have it's own package.
purvisa-at-google-com
pushed a commit
that referenced
this issue
Sep 29, 2022
Image Format conversion in AGI done by the converters that are registered in init time of Go Packages. There are details about this but simply init function in go packages runs before main when the packages are loaded. Recently #651 moved ETC conversion to its own packages similar to ASTC but different from ASTC, image creation remained in the parent package. As all the conversion functions called via register map that has registered during the init, this causes no function from the etc package, which ended up with it's not being loaded therefore no converter registered. This is a workaround that just create translator functions to reflect the image create functions in the parent package and uses those functions in Vulkan/resources to ensure the package is initialized. This is suboptimal and only a workaround. I am creating another PR with a refactor of the image formats. This is only a workaround until the other one can be merged.
purvisa-at-google-com
pushed a commit
that referenced
this issue
Sep 29, 2022
Fix ETC converter initialisation Image Format conversion in AGI done by the converters that are registered in init time of Go Packages. There are details about this but simply init function in go packages runs before main when the packages are loaded. Recently #651 moved ETC conversion to its own packages similar to ASTC but different from ASTC, image creation remained in the parent package. As all the conversion functions called via register map that has registered during the init, this causes no function from the etc package, which ended up with it's not being loaded therefore no converter registered. This is a workaround that just create translator functions to reflect the image create functions in the parent package and uses those functions in Vulkan/resources to ensure the package is initialised. This is suboptimal and only a workaround. I am creating another PR with a refactor of the image formats. This is only a workaround until the other one can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I built it on a windows10 pc. After successful build , I got the message when runing "do run gapic".
lots of thanks for your help in advance.
The text was updated successfully, but these errors were encountered: