deviceinfo: Fix character encoding for GetComputerName. #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be UTF8. Fixes: google#651
AWoloszyn
reviewed
Jun 29, 2017
| if (!GetComputerNameW(host_wide, &size)) { | ||
| snprintf(gContext.mError, sizeof(gContext.mError), | ||
| "Couldn't get host name: %d", GetLastError()); | ||
| } |
There was a problem hiding this comment.
I think we want an early-return here. If we host_wide is empty, or garbage, I would be worried about what WideCharToMultiByte would return.
There was a problem hiding this comment.
Agreed, that's a real mistake. Thanks for spotting.
|
Done |
AWoloszyn
approved these changes
Jun 29, 2017
RenfengLiu
pushed a commit
to RenfengLiu/gapid
that referenced
this pull request
Apr 23, 2020
* Fixed anc code cleanup for skeletal animation Refs google#669 * Fix android build
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
In an ANGLE AGI trace, the thumbnail/resources of the containing OpenGL group and the OpenGL drawcall displayed out-of-date data. Updated these representations at query-time to reflect the correct Vulkan state. Test: Manual
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be UTF8.
Fixes: #651