Added subcommands to resource view. #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
suggested changes
Jul 24, 2017
gapis/api/cmd_extras.go
Outdated
| @@ -60,6 +61,20 @@ func (e *CmdExtras) Add(es ...CmdExtra) { | |||
| } | |||
| } | |||
|
|
|||
| // CloneFromOrPanic clones on or more CmdExtras to the list of CmdExtras, | |||
| // if there was an error, a panic is raised | |||
| func (e *CmdExtras) CloneFromOrPanic(es ...CmdExtra) { | |||
There was a problem hiding this comment.
We've used MustXXX() for the no-error form of XXX() methods elsewhere
| @@ -312,7 +312,7 @@ func cutCommandBuffer(ctx context.Context, id api.CmdID, | |||
| // idx[3] is the secondary command buffer index inside a vkCmdExecuteCommands | |||
| // idx[4] is the secondary command inside the secondary command-buffer | |||
| submitCopy := cb.VkQueueSubmit(a.Queue, a.SubmitCount, a.PSubmits, a.Fence, a.Result) | |||
| submitCopy.Extras().Add(a.Extras().All()...) | |||
| submitCopy.Extras().CloneFromOrPanic(a.Extras().All()...) | |||
There was a problem hiding this comment.
Why not just: submitCopy := deep.MustClone(a).(*VkQueueSubmit) ?
There was a problem hiding this comment.
The only reason is that we use Add(a.Extras().All()....) A lot elsewhere, when we are not cloning an atom.
gapis/resolve/state.go
Outdated
| s, err := capture.NewState(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| for _, cmd := range cmds { | ||
| log.W(ctx, "State: %+v", cmd) |
There was a problem hiding this comment.
Thanks! I missed that one.
|
LGTM |
AWoloszyn
force-pushed
the
subcommand-resources
branch
from
91aafb0 to
887c422
Compare
ben-clayton
reviewed
Jul 24, 2017
| @@ -60,6 +61,20 @@ func (e *CmdExtras) Add(es ...CmdExtra) { | |||
| } | |||
| } | |||
|
|
|||
| // MustClone clones on or more CmdExtras to the list of CmdExtras, | |||
ben-clayton
approved these changes
Jul 24, 2017
This allows us to get textures from subcommands.
AWoloszyn
force-pushed
the
subcommand-resources
branch
from
887c422 to
0020561
Compare
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
Fix ETC converter initialisation Image Format conversion in AGI done by the converters that are registered in init time of Go Packages. There are details about this but simply init function in go packages runs before main when the packages are loaded. Recently #651 moved ETC conversion to its own packages similar to ASTC but different from ASTC, image creation remained in the parent package. As all the conversion functions called via register map that has registered during the init, this causes no function from the etc package, which ended up with it's not being loaded therefore no converter registered. This is a workaround that just create translator functions to reflect the image create functions in the parent package and uses those functions in Vulkan/resources to ensure the package is initialised. This is suboptimal and only a workaround. I am creating another PR with a refactor of the image formats. This is only a workaround until the other one can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to get textures from subcommands.