Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Particles and Particles2D preprocess property doesn't do anything #12460

Closed
CowThing opened this issue Oct 28, 2017 · 1 comment · Fixed by #13277
Closed

Particles and Particles2D preprocess property doesn't do anything #12460

CowThing opened this issue Oct 28, 2017 · 1 comment · Fixed by #13277
Labels
bug topic:core
Milestone
3.0

Comments

@CowThing
Copy link
Contributor

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10 64bit - Godot 3.0 master

Issue description:
I added a Particle node to the scene and I set the particle lifetime to 5, and the preprocess time to 5. But when I play the scene the particle system start from the beginning, and doesn't have 5 seconds worth of preprocessing. This happens to both 3D and 2D particles.
@akien-mga akien-mga added this to the 3.0 milestone Nov 1, 2017
@kubecz3k kubecz3k mentioned this issue Nov 3, 2017
Closed
30 tasks
@jesperkondrup
Copy link

This is the same issue in 2.1.4, the "Preprocess" variable does not seem to do anything.

DoctorAlpaca added a commit to DoctorAlpaca/godot that referenced this issue Nov 25, 2017
@DoctorAlpaca
Fix particle preprocessing. Fixes godotengine#12460.
57845b5 
Remove an incorrect check likely left over from copying from the
normal fixed_fps update case.

Also makes sure that the preprocessing_time is always fully simulated,
rather overshooting the mark than stopping early.
@DoctorAlpaca DoctorAlpaca mentioned this issue Nov 25, 2017
Merged
@Keetz Keetz mentioned this issue Nov 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Fix particle preprocessing DoctorAlpaca/godot
3 participants
@akien-mga @CowThing @jesperkondrup