Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 8.0 #2847

Merged
merged 30 commits into from
Jan 20, 2025
Merged

Release 8.0 #2847

merged 30 commits into from
Jan 20, 2025

Conversation

brianhogg
Copy link
Contributor

No description provided.

@brianhogg brianhogg requested a review from ideadude as a code owner January 9, 2025 17:47
brianhogg and others added 15 commits January 9, 2025 15:52
* Core support for Beaver Builder. LifterLMS Labs not required.
Do not unload the textdomain when it may have already loaded, and before trying to load.
* Statement about privacy should not be a form label element.
* Heading of login form should be h2 - hierarchical heading order
* Heading of registration form should be h2 - hierarchical heading order
* Adding alt text to LifterLMS icon in wp adminbar
* Notifications should not use a heading tag because we cannot reliably guess the proper hierarchical level
* Enlarging form fields and submit button that was being cut too short
* Enlarging space for form button that was being cut off
* Locked lessons accessibility
* Allow aria-label in our form fields sanitization
* Adding verbose parameter to the get_enroll_text method for more accessibility pricing / access plan buttons.
* Adding accessible enroll / access plan button text
* Fixing failing E2E tests.

---------

Co-authored-by: Kim Coleman <[email protected]>
Co-authored-by: Jason Coleman <[email protected]>
Co-authored-by: Jason Coleman <[email protected]>
* Avoid checking if plugin is installed right after installing it, since the methods aren't loaded into memory yet. There was also a typo sprtinf() before.
* Add a second API call to get the redirect URL after installing the plugin. Otherwise the plugin isn't yet loaded and available.
* Add additional HTML tags allowed via wp_kses_post to the allowed HTML form fields, and use this broader list for the quiz question description.
* Proper handling when there are multiple elements on which llmsPostsSelect2 is called, by looping over each one.

* Changelog.

* Removing debugger.

* Screenshots to try and diagnose e2e test fail. Switch to clickButton.

* Importing clickButton
…t Date set (#2844)

* If the lesson would be restricted by the course start date, but the lesson has "# days after enrollment" drip settings, use that restriction instead.
* Adding lifterlms_membership_instructors shortcode and Beaver Builder module.
* Adding membership template, and migration method for memberships to add in the instructor and pricing modules in Beaver Builder.
* Adding membership as enabled post type by default.
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.18% 328/425
🟡 Branches 68.45% 141/206
🟢 Functions 82.93% 68/82
🟡 Lines 76.68% 319/416

Test suite run success

169 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from 84636e0

brianhogg and others added 3 commits January 16, 2025 15:43
* Turning the favorite icon into a button for accessibility. Moving favorite and has quiz/assignment into new "meta" row since you can't have a button inside a link.
* Moving entire lesson link + meta into a section. Fixes spacing between lesson favorite and the has quiz/assignment text.
* Moving hover/background styling to the section so the hover effects look better.
* Switching javascript for button action. Removing build file.
* Moving formatting of button to work for both syllabus and the individual lesson page. Fixing tooltip for locked lessons.
* Hide "has quiz/assignment" if we're on an individual lesson.
* Fixing the accessibility of the review form.

* Changelog
…ntor and Beaver Builder for accessibility (header order).
@brianhogg brianhogg merged commit 7dc84b5 into trunk Jan 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants