-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 8.0 #2847
Merged
Release 8.0 #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding purchase checkout link in header, always displayed. * Fixes checkout URL if the domain isn't included.
* Avoid text in buttons from wrapping. Similar styling to WP core.
* Core support for Beaver Builder. LifterLMS Labs not required.
Do not unload the textdomain when it may have already loaded, and before trying to load.
* Statement about privacy should not be a form label element. * Heading of login form should be h2 - hierarchical heading order * Heading of registration form should be h2 - hierarchical heading order * Adding alt text to LifterLMS icon in wp adminbar * Notifications should not use a heading tag because we cannot reliably guess the proper hierarchical level * Enlarging form fields and submit button that was being cut too short * Enlarging space for form button that was being cut off * Locked lessons accessibility * Allow aria-label in our form fields sanitization * Adding verbose parameter to the get_enroll_text method for more accessibility pricing / access plan buttons. * Adding accessible enroll / access plan button text * Fixing failing E2E tests. --------- Co-authored-by: Kim Coleman <[email protected]> Co-authored-by: Jason Coleman <[email protected]> Co-authored-by: Jason Coleman <[email protected]>
* Avoid checking if plugin is installed right after installing it, since the methods aren't loaded into memory yet. There was also a typo sprtinf() before. * Add a second API call to get the redirect URL after installing the plugin. Otherwise the plugin isn't yet loaded and available.
…board login form (#2818) --------- Co-authored-by: Kim Coleman <[email protected]>
* Add additional HTML tags allowed via wp_kses_post to the allowed HTML form fields, and use this broader list for the quiz question description.
* Proper handling when there are multiple elements on which llmsPostsSelect2 is called, by looping over each one. * Changelog. * Removing debugger. * Screenshots to try and diagnose e2e test fail. Switch to clickButton. * Importing clickButton
…t Date set (#2844) * If the lesson would be restricted by the course start date, but the lesson has "# days after enrollment" drip settings, use that restriction instead.
… lesson Favourite is enabled.
* Adding lifterlms_membership_instructors shortcode and Beaver Builder module. * Adding membership template, and migration method for memberships to add in the instructor and pricing modules in Beaver Builder. * Adding membership as enabled post type by default.
Coverage report
Test suite run success169 tests passing in 22 suites. Report generated by 🧪jest coverage report action from 84636e0 |
* Turning the favorite icon into a button for accessibility. Moving favorite and has quiz/assignment into new "meta" row since you can't have a button inside a link. * Moving entire lesson link + meta into a section. Fixes spacing between lesson favorite and the has quiz/assignment text. * Moving hover/background styling to the section so the hover effects look better. * Switching javascript for button action. Removing build file. * Moving formatting of button to work for both syllabus and the individual lesson page. Fixing tooltip for locked lessons. * Hide "has quiz/assignment" if we're on an individual lesson. * Fixing the accessibility of the review form. * Changelog
…ntor and Beaver Builder for accessibility (header order).
* Updating lifterlms-blocks version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.