Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q3 cycle accessibility #2834

Merged
merged 30 commits into from
Jan 13, 2025
Merged

Q3 cycle accessibility #2834

merged 30 commits into from
Jan 13, 2025

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Dec 16, 2024 •
edited
Loading

Description

Additional accessibility changes across the plugin.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

kimcoleman and others added 20 commits May 15, 2024 10:42
@kimcoleman
Added Block setting and Shortcode attribute to display Student Accoun…
b19b1db 
…t Dashboard as stacked or columns (#2651)
@brianhogg
Merge branch 'dev' into v7.7
785d42e
@ideadude
Merge branch 'dev' into v7.7
837adf0
@brianhogg
Merge branch 'dev' into v7.8
f048764
@kimcoleman @ideadude @brianhogg
Access Plans UI Updates (#2682)
3d44023 
* Fixing overlapping label and hidden label text, adding changelogs
* Adding upsell to Ecommerce Add-ons if none are enabled (manual only).
* Adding UTM parameters to commerce Add-ons link

---------

Co-authored-by: Jason Coleman <[email protected]>
Co-authored-by: Brian Hogg <[email protected]>
@brianhogg
Merge branch 'dev' into v7.8
61f573f
@kimcoleman
Statement about privacy should not be a form label element.
372b888
@kimcoleman
Heading of login form should be h2 - hierarchical heading order
4a6c8bc
@kimcoleman
Heading of registration form should be h2 - hierarchical heading order
68e47da
@kimcoleman
Hidden select field should still have a referenced form label element
70f2b5b
@kimcoleman
Adding alt text to LifterLMS icon in wp adminbar
9fe3377
@kimcoleman
Notifications should not use a heading tag because we cannot reliably…
27b49b1 
… guess the proper hierarchical level
@kimcoleman
Enlarging form fields and submit button that was being cut too short
d79b046
@kimcoleman
Enlarging space for form button that was being cut off
9a42bdc
@kimcoleman
Locked lessons accessibility
515a35e
@kimcoleman
Merge branch 'dev' into q3-cycle-a11y
95f13fb
@kimcoleman
Merge branch 'dev' of https://github.com/gocodebox/lifterlms into q3-…
69ee435 
…cycle-a11y
@kimcoleman
Allow aria-label in our form fields sanitization
2715425
@kimcoleman
Adding verbose parameter to the get_enroll_text method for more acces…
0459f36 
…sibility pricing / access plan buttons.
@kimcoleman
Adding accessible enroll / access plan button text
706b73a
@brianhogg brianhogg added this to the Next Available Release milestone Dec 16, 2024
@brianhogg brianhogg self-assigned this Jan 9, 2025
@brianhogg brianhogg marked this pull request as ready for review January 9, 2025 17:33
@brianhogg brianhogg requested a review from ideadude as a code owner January 9, 2025 17:33
@brianhogg brianhogg merged commit 0f74e20 into dev Jan 13, 2025
24 checks passed
@brianhogg brianhogg deleted the q3-cycle-a11y branch January 13, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideadude ideadude Awaiting requested review from ideadude ideadude is a code owner

Assignees

@brianhogg brianhogg

Labels
None yet
Projects
Development
Status: Done
Milestone
Next Available Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brianhogg @kimcoleman @ideadude