Lesson preview favorite and review accessibility #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orite and has quiz/assignment into new "meta" row since you can't have a button inside a link.
…n lesson favorite and the has quiz/assignment text.
…ual lesson page. Fixing tooltip for locked lessons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switching lesson action from an icon that was not an interactive element (keyboard accessible) to a button, with
aria-pressedAlso adding labels to the "write a review" form
Fixes #2852
How has this been tested?
Manually
Screenshots
CleanShot.2025-01-16.at.12.31.26.mp4
Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected) for themes expecting it to be an icon.
Checklist: