feat: add validation for secret block #126
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 95.96% 94.98% -0.98%
==========================================
Files 50 50
Lines 3147 3270 +123
==========================================
+ Hits 3020 3106 +86
- Misses 73 90 +17
- Partials 54 74 +20
|
yaml/secret.go
Outdated
| return isInvalid, fmt.Errorf("failed compile: unable to annotate: %w", err) | ||
| } | ||
|
|
||
| // nolint:lll // ignore line length |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive // nolint:lll // ignore line length is unused for linter lll (nolintlint)
There was a problem hiding this comment.
this means the nolint directive is not needed here, afaik
yaml/step.go
Outdated
| "provided for step %s:\n%s\n ", step.Name, string(source)), | ||
| ) | ||
| invalid = fmt.Errorf("%w: %s", invalid, | ||
| fmt.Errorf("no commands, environment, parameters, secrets or template provided for step %s:\n%s\n ", step.Name, string(source))) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 132 characters (lll)
There was a problem hiding this comment.
looks like we need a nolint here, or break up the line
yaml/secret.go
Outdated
| return isInvalid, fmt.Errorf("failed compile: unable to annotate: %w", err) | ||
| } | ||
|
|
||
| // nolint:lll // ignore line length |
There was a problem hiding this comment.
this means the nolint directive is not needed here, afaik
yaml/step.go
Outdated
| "provided for step %s:\n%s\n ", step.Name, string(source)), | ||
| ) | ||
| invalid = fmt.Errorf("%w: %s", invalid, | ||
| fmt.Errorf("no commands, environment, parameters, secrets or template provided for step %s:\n%s\n ", step.Name, string(source))) |
There was a problem hiding this comment.
looks like we need a nolint here, or break up the line
This PR is part of the work with the new Yaml library:
go-vela/community#9
This PR implements linting guidelines for the secret block. The checked fields follow the standard set by the schema.json in the latest release.