Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and test alternative yaml library (goccy/yaml) #9

Open
jbrockopp opened this issue May 27, 2020 · 4 comments · Fixed by go-vela/types#118 or go-vela/compiler#91
Open

Implement and test alternative yaml library (goccy/yaml) #9

jbrockopp opened this issue May 27, 2020 · 4 comments · Fixed by go-vela/types#118 or go-vela/compiler#91
Assignees
@kneal
Labels
area/compiler Indicates a change to the compiler dependencies Indicates a change to dependencies enhancement Indicates an improvement to a feature status/backlog Indicates the item is in the backlog
Milestone
Vela 0.7.0 Release

Comments

@jbrockopp
Copy link
Contributor

Description

Original stories:

Update our gopkg.in/yaml library to the v3 functionality.

https://github.com/go-yaml/yaml/tree/v3

Value

  • Reduce technical debt
  • Improve performance

Definition of Done

This repo is using the v3 release of the gopkg.in/yaml library.

Effort (Optional)

1 week

Impacted Personas (Optional)

everyone
@jbrockopp jbrockopp added dependencies Indicates a change to dependencies enhancement Indicates an improvement to a feature status/backlog Indicates the item is in the backlog area/compiler Indicates a change to the compiler labels May 27, 2020
@stale
Copy link

stale bot commented Jul 26, 2020

This issue has been automatically marked as stale due to no recent activity for the last 60 days.
It will be closed if no further activity occurs in the next 30 days.
Thank you for your contributions!

@stale stale bot added the stale Indicates inactive for 60+ days label Jul 26, 2020
@kneal kneal added this to the Vela 0.7.0 Release milestone Oct 7, 2020
@kneal kneal changed the title Update gopkg.in/yaml (go-yaml/yaml) to v3 investigate alternative yaml libraries Oct 7, 2020
@kneal
Copy link

kneal commented Oct 7, 2020

Today we use: buildkite/yaml (last commit Oct 16th, 2018)

Above is a fork of: go-yaml/yaml (last commit Jun 2nd, 2020)

The option we are thinking about moving toward: goccy/yaml (last commit Sep 18th, 2020)

@kneal kneal removed the stale Indicates inactive for 60+ days label Oct 7, 2020
@plyr4 plyr4 changed the title investigate alternative yaml libraries implemenet and test alternative yaml libraries Oct 12, 2020
@plyr4 plyr4 changed the title implemenet and test alternative yaml libraries implemenet and test alternative yaml library (goccy/yaml) Oct 12, 2020
@plyr4 plyr4 changed the title implemenet and test alternative yaml library (goccy/yaml) implement and test alternative yaml library (goccy/yaml) Oct 12, 2020
@plyr4 plyr4 changed the title implement and test alternative yaml library (goccy/yaml) Implement and test alternative yaml library (goccy/yaml) Oct 12, 2020
@kneal kneal self-assigned this Nov 17, 2020
@kneal kneal added status/in-progress Indicates the item is in progress and removed status/backlog Indicates the item is in the backlog labels Nov 20, 2020
@kneal
Copy link

kneal commented Dec 2, 2020

Initial PR testing out the goccy/go-yaml library

go-vela/types#118

Types ad-hoc tests looked good but the real testing will need to happen once this change is pulled into the compiler.

This was referenced Dec 2, 2020
Merged
Merged
@kneal kneal mentioned this issue Jan 4, 2021
Merged
@jbrockopp jbrockopp reopened this Jan 18, 2022
@jbrockopp jbrockopp mentioned this issue Jan 18, 2022
Closed
@cognifloyd
Copy link
Member

go-vela/types#118 was reverted in go-vela/types#144
go-vela/compiler#91 was reverted in go-vela/compiler#133

I don't see a description of why they were reverted or where exactly behavior differs between buildkite/yaml and goccy/go-yaml.

Was it merge keys or anchors or ...?

@jbrockopp jbrockopp added status/backlog Indicates the item is in the backlog and removed status/in-progress Indicates the item is in progress labels May 25, 2022
@KellyMerrick KellyMerrick mentioned this issue Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kneal kneal

Labels
area/compiler Indicates a change to the compiler dependencies Indicates a change to dependencies enhancement Indicates an improvement to a feature status/backlog Indicates the item is in the backlog
Projects
None yet
Milestone
Vela 0.7.0 Release
Development

Successfully merging a pull request may close this issue.

refactor: swap yaml libraries go-vela/types
refactor: swap yaml libraries go-vela/compiler
3 participants
@cognifloyd @jbrockopp @kneal