This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
refactor: swap yaml libraries #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneal
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 73.34% 71.50% -1.85%
==========================================
Files 19 18 -1
Lines 818 779 -39
==========================================
- Hits 600 557 -43
- Misses 143 145 +2
- Partials 75 77 +2
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -30,17 +32,17 @@ | |||
| } | |||
|
|
|||
| // Compile produces an executable pipeline from a yaml configuration. | |||
| func (c *client) Compile(v interface{}) (*pipeline.Build, error) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Function 'Compile' has too many statements (73 > 50) (funlen)
jbrockopp
suggested changes
Jan 11, 2021
wass3r
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is towards an effort to consolidate on a single Yaml library for unmarshaling pipelines.
The plan is to work towards goccy/go-yaml being the core library.
It has the desired feature we would like to use in the compiler to enhance the error handling for users passing improper pipelines.
depends on: go-vela/types#118 go-vela/types#126
closes: go-vela/community#9