-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
I am again experiencing the issue I reported in #1639 (comment). This time also for Chrome. |
I also got toast notification for orders made with a different account. |
@MareenG I won't address this one in this PR, because is not 100% related and we will need to add a few changes that will be undone in a upcoming PR (Order APIs)
yep, what i mentioned in the description |
Hey @anxolin , should approve/wrap/unwrap transactions follow this logic in this PR? Btw, in this video you can see an issue reported by Mareen that an order from one network is displayed for another network. |
Co-authored-by: Leandro Boscariol <[email protected]>
It should! Let me review what was wrong.
YEp, that's what I mentioned. This part I won't fix it. I will wait for the order API that leandro is doing just to not put effort in sth that will go away soon. This issue is already in production and there's not much complaints about that |
For me is working. I tried for example unwrapping, each account has its own tx. Nov-05-2021.18-51-09.mp4Nov-05-2021.18-48-16.mp4Elena, I will merge it, we still will do some tests for the RC before deploying this, if the issue persists we will look further. |
Hey @anxolin , I have retested changes. |
Summary
This PR makes the recent activity not to show all the activities from all accounts anymore.
Now, only the connected wallet will be displayed.
Not included
It doesn't prevent the process that check if tx are mined in the background (aka: Updater) to stop checking on other account's tx.
This is why you might hear a mooooo even thought there's "nothing pending" for the current account.
A future PR will address this.
To Test
Background
This is part of what Leandro is doing for loading orders from the API: #1639
However, his Pr is more ambitious, and will take a bit more to complete.
This will be just a temporary feature while we don't have the loading of orders from the API.