[Recent Orders] - Orders displayed in the wrong network

[MareenG]

Description
First reported in PR #1639
#1639 (comment)
#1639 (comment)
Also appeared in #1783

Some orders of other network are displayed in the activities overview.
Eg. Xdai trades in Mainnet or Rinkeby trades when selecting xDai

First it only happened when using FF or Brave now also for Chrome

How to Reproduce
Steps to reproduce the behavior:

1. Go to PRs 1639 or 1783 and open cowswap
2. Perform trades in different networks
3. Open trading activites and cross check the trades
4. trades are displayed in wrong network

Expected behavior
xDai trades only shown when xDai selected
Mainnet for Mainnet
Rinkeby for Rinkeby

Screenshots

[MareenG]

Also it looks like it doesn't properly update the recent activities of the wrong network:

[MareenG]

Deleting redux_localstorage_simple_orders cleared the order activites and the orders of the wrong network where removed

[elena-zh]

It seems that I faced a similar issue a couple of weeks ago #1618
Anyways, let these issues be linked.

[alfetopito]

To be clear, is this happening ONLY on my PR where orders are loaded from api or ALSO regular loading (stored in the browser)?

[MareenG]

@alfetopito The orders displayed in the wrong network ONLY happen in your PR (#1639) and the one from Anxo (#1783)

That orders might not update properly happened to Elena before as described in #1618

[alfetopito]

Hmm, then this is more general and not necessarily related to account separation nor orders from API, as reported by Elena on #1618
At least we know this hasn't been introduced with any of those changes.

I suspect this might be there for awhile and it should be reproducible on develop / 1.5 branches, if introduced with the SC integration, or even be on prod.

Need more debugging to find out what's causing it

[elena-zh]

No longer reproducible.