[Safe] Handle the case: Enough signatures, but not transaction

[anxolin]

Summary

This PR tries to tackle the edge case where an user signed the transaction with enough signers, but they didn't execute the transaction.

It will be shown like this:

The user will need to go to Gnosis Safe and execute the transaction:

To Test

1. Sign a transaction with all the required signers. The last signer should uncheck the "Execute transaction" checkbox before signing.
2. Verify message in CowSwap
3. Sign the transaction
4. Verify message in CowSwap

[github-actions]

• 🔭 GP Swap: Gnosis Protocol v2 Swap UI

[elena-zh]

Hey @anxolin , I reviewed changes. Great job!

I'd like to add an enhancement proposal: When an order is signed and executed, and is in 'Open' status, it would be nice stop displaying 'Need to execute' message and replace it with 'Executed' one. WDYT?

Some minor UI issues I found, but they might be fixed by @biocom :

1. It would be nice to change 'Need to execute' message color in the light mode. At least, make it the same with the 'Filled' status. I think
   

2. It would be nice to add a margin between the message and the 'View Gnosis Safe' link
   

[alfetopito]

Happy case working good.

Agree with Elena's comments on hiding the signature threshold completely when pre-sign tx executed.

[fairlighteth]

I'd like to add an enhancement proposal: When an order is signed and executed, and is in 'Open' status, it would be nice stop displaying 'Need to execute' message and replace it with 'Executed' one. WDYT?

If all signatures are collected + the pre-sign transaction is executed, the order then can go proceed to status OPEN. In that case we don't need the 'need to execute' message anymore. I do think it's convenient to still show some brief 'history' as in, how many signatures were collected. As a nice to have.

The light mode green color is something I will fix with a waterfall PR on this one.

[anxolin]

I'd like to add an enhancement proposal: When an order is signed and executed, and is in 'Open' status, it would be nice stop displaying 'Need to execute' message and replace it with 'Executed' one. WDYT?

Good idea! this happens for a delay, but your proposal is good! Will do it now

[fairlighteth]

@elena-zh @anxolin Addressed the style issues in #1700

Also an issue I spotted when testing: Been testing a Safe (on Rinkeby) with a threshold of 2 signatures. The second confirmed signature (execution was unchecked) didn't seem to get updated on the CowSwap end. I did verify the Safe endpoint returning 2 confirmations (no execution).

[anxolin]

@elena-zh I implemented your proposal! thanks for the tip

@alfetopito addressed your comments too.

@biocom thanks for the PR, I will review soon

Also an issue I spotted when testing: Been testing a Safe (on Rinkeby) with a threshold of 2 signatures. The second confirmed signature (execution was unchecked) didn't seem to get updated on the CowSwap end. I did verify the Safe endpoint returning 2 confirmations (no execution).

We can see this in a zoom after/before our sync

[anxolin]

I'll do a simple merge to #1652 since I have one approval and that other PR is related and @elena-zh has reported the same issue in both places.

This way the fix to one of the issues will be already applied :)