Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Trailling . on formatted amounts #1316

Closed
alfetopito opened this issue Aug 25, 2021 · 0 comments · Fixed by #1967
Closed

Trailling . on formatted amounts #1316

alfetopito opened this issue Aug 25, 2021 · 0 comments · Fixed by #1967
Assignees
@alfetopito
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@alfetopito
Copy link
Contributor

alfetopito commented Aug 25, 2021 •
edited by elena-zh
Loading

Hey @alfetopito , it might be another edge case, but it would be nice to remove a period in the end of a number when a decimal part is rounded to 0
image

However, based on the lib info, here we should show 1 decimal number
image

Originally posted by @elena-zh in #1281 (comment)

Added: the same is for balances, token amounts
image
image
@alfetopito alfetopito self-assigned this Aug 25, 2021
@alfetopito alfetopito added app:CowSwap CowSwap app Bug Something isn't working labels Aug 25, 2021
@elena-zh elena-zh added the Medium Severity indicator. It causes some undesirable behavior, but the system is still functional label Aug 26, 2021
@elena-zh elena-zh mentioned this issue Sep 21, 2021
Merged
This was referenced Dec 2, 2021
Merged
Merged
@mergify mergify bot closed this as completed in #1967 Dec 6, 2021
mergify bot pushed a commit that referenced this issue Dec 6, 2021
@alfetopito
Bump dex-js to 0.13.0 to fix issue with trailing dot (#1967)
fc98999 
# Summary

Fixes #1316 

The actual fix was on dex-js gnosis/dex-js#300

This change is simply bumping the lib version on CowSwap

  # To Test

1. Pick a pair and fill in an absurd high amount
2. Wait until the receive amount is something that ends in  `.0` - well, you actually won't see that because you should see instead no trailing dots nor zeros
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alfetopito alfetopito

Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump dex-js to 0.13.0 to fix issue with trailing dot gnosis/cowswap
2 participants
@alfetopito @elena-zh