-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably just rounding as I believe the same display logic is on prod and dev |
Hmm I think the screenshots I shared aren't the right ones 🤔 . I was referring to seeing a truncated fiat value for the input field, looking something like '$342324.' I guess it looked weird to me seeing a number truncated ending with a dot/decimal. But can't reproduce for now... |
this might be reported in #1316 |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍x2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, works as expected. Only concern is their API failing some times...
Yes, it was mentioned before https://gnosisinc.slack.com/archives/C025G521XQD/p1632209701016600. Could be that our code sometimes produces more then one request to Paraswap almost instantly or in the time span of few seconds and they now limit some of those but I'm not sure about this. |
Summary
Fixes #1378
migration from Paraswap v4 to v5
To Test
Note