This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Cowswap 1316/trailling dot #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
approved these changes
Dec 3, 2021
mergify bot
pushed a commit
to gnosis/cowswap
that referenced
this pull request
Dec 6, 2021
# Summary Fixes #1316 The actual fix was on dex-js gnosis/dex-js#300 This change is simply bumping the lib version on CowSwap # To Test 1. Pick a pair and fill in an absurd high amount 2. Wait until the receive amount is something that ends in `.0` - well, you actually won't see that because you should see instead no trailing dots nor zeros
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of gnosis/cowswap#1316
Do not return values with trailing dots
Testing