Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import and call related to 'configob.verify'. #302

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Mar 7, 2020

Fixes issue #301.

Motivation and Context

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

Example for a changelog entry: Fix issue with launching rockets to the moon (#101, #212).

@csadorf csadorf requested review from a team as code owners March 7, 2020 08:50
@csadorf csadorf requested review from atravitz and pepak13 and removed request for a team and pepak13 March 7, 2020 08:50
@csadorf
Copy link
Contributor Author

csadorf commented Mar 7, 2020

@vishav1771 This should fix the bug you uncovered in #300 . Would you mind reviewing this PR?

@csadorf csadorf mentioned this pull request Mar 7, 2020
12 tasks
@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #302 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          40       40           
  Lines        5700     5700           
=======================================
  Hits         3714     3714           
  Misses       1986     1986           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2d8c4...abf6779. Read the comment docs.

@vishav1771
Copy link
Contributor

@csadorf I tried it locally. LGTM 👍

@bdice bdice added this to the v1.4.1 milestone Mar 7, 2020
@bdice bdice added the bug Something isn't working label Mar 7, 2020
@bdice bdice linked an issue Mar 7, 2020 that may be closed by this pull request
@bdice bdice merged commit f60bef3 into master Mar 10, 2020
@bdice bdice deleted the fix/issue-301 branch March 10, 2020 18:38
@bdice bdice modified the milestones: v1.4.1, v1.5.0 Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'signac config verify' is broken
4 participants