Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import and call related to 'configob.verify'. #302

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Fix import and call related to 'configob.verify'. #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0489093
Fix import and call related to 'configob.verify'.
csadorf Mar 7, 2020
abf6779
Update changelog.
csadorf Mar 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ The **signac** package follows `semantic versioning <https://semver.org/>`_.
Version 1
=========

next
----

- Fix the ``signac config verify`` command (previously broken) (#301, #302).

[1.4.0] -- 2020-02-28
---------------------

Expand Down
3 changes: 1 addition & 2 deletions signac/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,8 +718,7 @@ def main_update_cache(args):
#
#
def verify_config(cfg, preserve_errors=True):
verification = cfg.verify(
preserve_errors=preserve_errors, skip_missing=True)
verification = cfg.verify(preserve_errors=preserve_errors)
if verification is True:
_print_err("Passed.")
else:
Expand Down
2 changes: 1 addition & 1 deletion signac/common/configobj/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2082,7 +2082,7 @@ def validate(self, validator, preserve_errors=False, copy=False,
if preserve_errors:
# We do this once to remove a top level dependency on the validate module
# Which makes importing configobj faster
from configobj.validate import VdtMissingValue
from .validate import VdtMissingValue
self._vdtMissingValue = VdtMissingValue

section = self
Expand Down