Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'signac config verify' is broken #301

Closed
csadorf opened this issue Mar 7, 2020 · 0 comments · Fixed by #302
Closed

'signac config verify' is broken #301

csadorf opened this issue Mar 7, 2020 · 0 comments · Fixed by #302
Assignees
Labels
bug Something isn't working
Milestone

Comments

@csadorf
Copy link
Contributor

csadorf commented Mar 7, 2020

Description

The signac config verify CLI command is currently broken, as was discovered during the implementation of #300 .

To reproduce

Execute signac config verify on the command line.

~/local/signac $ signac --debug config verify
DEBUG:signac.common.config:Reading config file '/Users/csadorf/.signacrc'.
DEBUG:signac.common.validate:Install pymongo to validate database configurations!
# ... omitting many repeats of the above message
DEBUG:signac.common.config:Config file '/Users/csadorf/.signacrc' may contain invalid values.
DEBUG:signac.common.config:Reached filesystem root.
Error: validate() got an unexpected keyword argument 'skip_missing'
Traceback (most recent call last):
  File "/Users/csadorf/miniconda3/envs/signac-dev/bin/signac", line 11, in <module>
    load_entry_point('signac', 'console_scripts', 'signac')()
  File "/Users/csadorf/local/signac/signac/__main__.py", line 1835, in main
    args.func(args)
  File "/Users/csadorf/local/signac/signac/__main__.py", line 809, in main_config_verify
    verify_config(cfg)
  File "/Users/csadorf/local/signac/signac/__main__.py", line 721, in verify_config
    verification = cfg.verify(
  File "/Users/csadorf/local/signac/signac/common/config.py", line 133, in verify
    return super(Config, self).validate(validator, *args, **kwargs)
TypeError: validate() got an unexpected keyword argument 'skip_missing'

Error output

If possible, copy any terminal outputs or attach screenshots that provide additional information on the problem.

System configuration

macOS-10.11.6-x86_64-i386-64bit
3.8.1 | packaged by conda-forge | (default, Jan 29 2020, 15:06:10)
[Clang 9.0.1 ]
1.4.0
csadorf added a commit that referenced this issue Mar 7, 2020
@bdice bdice added this to the v1.4.1 milestone Mar 7, 2020
@bdice bdice added the bug Something isn't working label Mar 7, 2020
@bdice bdice linked a pull request Mar 7, 2020 that will close this issue
12 tasks
bdice pushed a commit that referenced this issue Mar 10, 2020
* Fix import and call related to 'configob.verify'.

Fixes issue #301.

* Update changelog.
@bdice bdice modified the milestones: v1.4.1, v1.5.0 Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants