Release 2.0.779 #746
Merged
Release 2.0.779 #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-light Make Azure Repos OAuth non-experimental
Update README.md to call out explicitly supported Linux distributions.
docs: add supported Linux distributions to README.md
Add GitLab to list of supported host providers.
Link to GitLab support docs
docs: highlight GitLab support in README.md
Lint markdown
Add an entry to the FAQ doc explaining how to revoke access to the GCM OAuth app for github.com
Add github.com OAuth app revoke instructions to FAQs
Signed-off-by: Easwar Hariharan <[email protected]>
Update WSL guide to reflect GCM's move from the libexec/git-core directory in Git for Windows to the bin directory.
docs: update WSL guide with new Git For Windows path
Pass through $PATH to find dotnet
Avoid writing out credentials that are the same as an already existing cred.
Avoid writing credentials when account & password have not changed
BitbucketHostProvider: fix runtime exceptions when authentication requests for Bitbucket DC would incorrectly call a Bitbucket Cloud REST API A bug was introduced in commit: 5a2cfd7. Prior to this only authentication requests for Bitbucket Cloud would try and automatically determine if 2FA was required by the current user by calling a Bitbucket Cloud REST API using user provided Basic Auth credentials Commit: 5a2cfd7 removed checking of the current host was Bitbucket Cloud vs DC. This meant the check would be run for Bitbucket Cloud and DC regardless. It would fail for Bitbucket DC The fix is more radical than simply re-instating the check on the type of Bitbucket host. From 1st March 2022 support for using a Bitbucket Cloud user's account password to access REST or Git HTTPS operations has been removed, https://atlassian.community/t5/x/x/ba-p/1948231. As such this automatic test to see if 2FA is required no longer works. Therefore the check against the Bitbucket Cloud REST API has been removed in its entirety
Fix the Ubuntu uninstall command which used the wrong package name.
dscho
approved these changes
Jun 15, 2022
Fix a bug whereby we would not correctly match existing credentials when port numbers were used in the search. Additionally, actually now store the non-default port number in the target URI if there is one given. We also now always trim any trailing '/' from the end of the path of a service/target URI. Previously we erronously only trimmed the '/' from a 'pathless' URI, i.e.: https://example.com/ => https://example.com https://example.com/path/ => https://example.com/path/ This is a safe change since the `Enumerate` method that is used by both `Get` and `Remove` already matches _both_ trailing and non-trailing slashes by virtue of creating and comparing components of a `System.Uri` which does normalisation of the path. Both `Get` and `Remove` would act (eventually) to remove any bad credentials stored with a trailing slash, even if new credentials are only written out without the slash.
Thanks @dscho! Quick reminder that we changed our asset naming a bit: |
Fix bug in Windows credential manager credential matching on port numbers
bitbucket: remove 2FA test
Inline some 2FA mock setup helper methods that differ only by a single boolean argument.
Rename some of the test/mock helper methods to be a little easier to grok/be shorter.
Remove the separate "OAuth Required" UI prompt in favour of just always showing the "Credentials" prompt, where users can select the OAuth auth mode directly anyway.
|
@ldennington do we want to also take #754 for this release? |
Depends on when we want to have it out by. Given the amount of progress I need to make on my proposal, I probably won't be able to review until tomorrow. Then we could plan to release on Wednesday with that PR after feedback has been addressed. Or we can release today. |
Automatically generate the correct application manifest for Windows executable projects that we produce. The manifests are required on Windows systems newer than Windows 8 to correctly access versioning APIs that will otherwise always report "Windows 8", even on later versions. The manifest we generate states we are compatible with all versions of Windows from 7 to 11 (inclusive).
Update shared UI helper code for Bitbucket to remove the separate OAuth prompt/command, and allow basic authentication (username/password) options to be hidden based on a command-line option.
Update the Avalonia-based UI for Bitbucket authentication to use a tabbed interface, showing each authentication mode in a separate tab. The new "credentials" prompt can offer and serve all authentication modes in a simpler way that pushes users who can to authenticate using a more secure method (where we don't capture the user/pass).
Update the WPF-based Bitbucket authentication prompt in a similar fashion to the Avalonia ones.
Generate Windows application manifests for all executable projects
New Bitbucket UI with separate OAuth and User/Pass options
|
@ldennington I think we're good to proceed with the current state of (Don't forget to update the release notes/PR description with the newly added PRs/fixes!) |
mjcheetham
approved these changes
Jun 22, 2022
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
$PATHinstead of usingwhichon POSIX systems (Manually scan$PATHon POSIX systems #717)read_repositoryscope to GitLab OAuth app (Addread_repositoryGitLab OAuth Scope #719)osx-arm64(Revise and consolidate osx-arm64 commits #732)Special thanks to our contributors 🎉: