-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab hostname only support. #699
Conversation
modified: src/shared/Core.Tests/UriExtensionsTests.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR! 🎉 I've added a few suggestions for cleanup, but looks good overall.
Co-authored-by: Lessley Dennington <[email protected]>
Thanks for your suggestions. I have reviewed and applied them. |
The
I.e, the empty string is also considered whitespace. |
Thanks for hinting. Sorry, should have figured that out myself. |
Closes #698 .
This merge request offers support for addressing git hosts by hostname only.
The overall idea of this implementation is: if a host uri does not contain any dots it has to be a host in the local network.
If thats the case the resulting credential scope is returned.
Otherwise the old scope determination algorithm applies.
UnitTest has been adapted. I am open for discussions or improvement suggestions.