Revise and consolidate osx-arm64 commits #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming specification of a macOS runtime led to the need to update the Microsoft.NET.Test.Sdk package. The old version, when combined with this specification, caused dependent packages to be downgraded, which resulted in NuGet errors. Upgrading to the latest version resolved this issue. Additionally, Avalonia has been upgraded to the latest version, which was necessitated by the upcoming changes to support osx-arm64.
mjcheetham
reviewed
Jun 10, 2022
| @@ -2,7 +2,7 @@ | |||
| <installer-gui-script minSpecVersion="1"> | |||
| <title>Git Credential Manager</title> | |||
| <background file="background.png" mime-type="image/png" alignment="bottomleft" scaling="tofit" /> | |||
| <options customize="never" /> | |||
| <options customize="never" hostArchitectures="x86_64,arm64" /> | |||
There was a problem hiding this comment.
I realise this was also in the first PR, but is correct?
There was a problem hiding this comment.
Mmmm no. Looks like the separate distribution files may have been dropped in the midst of a rebase. I will bring them back.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Add support for building osx-arm64 in addition to osx-x64 to produce native M1 binaries.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change revises the commits from #636 by:
osx-arm64support into two commits. The first commit lays the ground work for the changes by updating certain dependencies. The second commit implementsosx-arm64support.