Add ping heartbeat command #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
add-ping-command
branch
10 times, most recently
from
6c16cc6 to
fa7859a
Compare
QuentinBisson
force-pushed
the
add-ping-command
branch
from
fa7859a to
5a49061
Compare
|
@giantswarm/team-atlas could I get a review ? |
mcbenjemaa
suggested changes
Sep 6, 2022
cmd/ping.go
Outdated
| c := ctl.NewCtl(repo) | ||
|
|
||
| pings, err := c.Ping(opts.selectorOptions.ToConfig()) | ||
| for hbn, ping := range pings { |
There was a problem hiding this comment.
Actually, I think it's better to move this logic to the underlying function c.Ping()
so that, we only have one single loop.
There was a problem hiding this comment.
The err was handled after the loop, it's fixed now
I disagree with the loop management as logging to the console is a side effect of the function and I'm not sure we are really striving for that much optimization in that sample CLI :)
QuentinBisson
force-pushed
the
add-ping-command
branch
from
f518c8f to
a98e2b3
Compare
TheoBrigitte
requested changes
Sep 8, 2022
|
|
||
| - architect/push-to-docker: | ||
| name: push-to-docker | ||
| image: quay.io/giantswarm/heartbeatctl |
There was a problem hiding this comment.
What about other registries?
This was referenced Sep 8, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/23238