Add ping and tests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoBrigitte
requested changes
Sep 8, 2022
|
@giantswarm/team-atlas can I get a pair of eyes? |
TheoBrigitte
requested changes
Sep 15, 2022
QuentinBisson
commented
Sep 26, 2022
| } | ||
|
|
||
| if len(failedPings) > 0 { | ||
| return pingResults, fmt.Errorf("heartbeats \"%v\" failed", failedPings) |
There was a problem hiding this comment.
@TheoBrigitte does that addresses your comment?
There was a problem hiding this comment.
I am not sure how this printing shows, but yeah this addresses my concern. Thanks
There was a problem hiding this comment.
Thé array is printed as [cluster-id1 cluster-id2 ... Cluster-idn].
If this list is too Big, we have a Big issue
|
@TheoBrigitte can you take another look? |
TheoBrigitte
approved these changes
Sep 29, 2022
QuentinBisson
added a commit
that referenced
this pull request
Sep 29, 2022
* Fix build issues before pushing circle ci config * Fix build issues before pushing circle ci config * Configure circleci config * Add ping command and boilerplate * Add ping command impl and tests * Update ping.go * Address review * Fix tests Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
added a commit
that referenced
this pull request
Sep 29, 2022
* Fix build issues before pushing circle ci config * Fix build issues before pushing circle ci config * Configure circleci config * Add ping command and boilerplate * Add ping command impl and tests * Update ping.go * Address review * Fix tests Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
added a commit
that referenced
this pull request
Sep 29, 2022
* Add ping and tests (#16) * Fix build issues before pushing circle ci config * Fix build issues before pushing circle ci config * Configure circleci config * Add ping command and boilerplate * Add ping command impl and tests * Update ping.go * Address review * Fix tests Signed-off-by: QuentinBisson <[email protected]> * Release v0.1.0 Signed-off-by: QuentinBisson <[email protected]> Co-authored-by: Quentin Bisson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
QuentinBisson
added a commit
that referenced
this pull request
Sep 29, 2022
* Fix build issues before pushing circle ci config * Fix build issues before pushing circle ci config * Configure circleci config * Add ping command and boilerplate * Add ping command impl and tests * Update ping.go * Address review * Fix tests Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
added a commit
that referenced
this pull request
Sep 29, 2022
* Add ping and tests (#16) * Fix build issues before pushing circle ci config * Fix build issues before pushing circle ci config * Configure circleci config * Add ping command and boilerplate * Add ping command impl and tests * Update ping.go * Address review * Fix tests Signed-off-by: QuentinBisson <[email protected]> * Release v0.1.0 Signed-off-by: QuentinBisson <[email protected]> Co-authored-by: Quentin Bisson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/23238
Splitting of #3 part 3