Configure circleci config #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
update-circleci-config
branch
11 times, most recently
from
859bf7e to
f037ca4
Compare
QuentinBisson
force-pushed
the
update-circleci-config
branch
5 times, most recently
from
2d6a2bb to
9b387b6
Compare
QuentinBisson
force-pushed
the
update-circleci-config
branch
from
9b387b6 to
1cb250f
Compare
TheoBrigitte
approved these changes
Sep 8, 2022
| github.com/go-openapi/swag v0.19.5/go.mod h1:POnQmlKehdgb5mhVOsnJFsivZCEZ/vjK9gh66Z9tfKk= | ||
| github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg7847qk6SyHyPtNmDHnmrv/HOrqktSC+C9fM+CJOE= | ||
| github.com/gogo/protobuf v1.3.1/go.mod h1:SlYgWuQ5SjCEi6WLHjHCa1yvBfUnHcTbrrZtXPKa29o= | ||
| github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q= |
.circleci/config.yml
Outdated
| - go-build | ||
| filters: | ||
| tags: | ||
| only: /^v.*/ |
There was a problem hiding this comment.
What about the EOF here ? Please keep it
| @@ -1,3 +1,4 @@ | |||
| //go:build tools | |||
There was a problem hiding this comment.
This lines tells go that the imports in this file are not to be added to the go modules as they are build dependencies.
This file had // +build tools earlier so go generate can work but circleci requires //go:build tools
There was a problem hiding this comment.
I think this might be because we might have different go version here and in CI
TheoBrigitte
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/23238
Splitting of #3 part 1