-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include exception type in ignoreErrors tests #1057
Conversation
For what it's worth I think we should support that being a function instead of regexp optionally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My expectation would be that we append type
and message
together, and run the regex on that.
e.g. if you have type ReferenceError
, and message foo is not defined
, we'd run the regex against: ReferenceError: foo is not defined
No? What do other client libs do here? @mitsuhiko
@benvinegar only Ruby and Python have some sort of ignore options, and both of those SDKs use exception type only. The reason why I didn't want to append them together, is that |
5f79425
to
7dc7ce6
Compare
@benvinegar updated. // "Script error." is hard coded into browsers for errors that it can't read.
// this is the result of a script being pulled in from an external domain and CORS.
globalOptions.ignoreErrors.push(/^Script error\.?$/);
globalOptions.ignoreErrors.push(/^Javascript error: Script error\.? on line 0$/); Let's keep this feature in a separate issue. |
7dc7ce6
to
2869037
Compare
Yeah, I hear you. But I think everyone just expected it to work this way (I for one thought it did). |
We should also keep in mind that if people were doing this: |
True that, I missed that scenario. Hopefully most of people are using string based tests. |
Ref #1005 and #1007