Compare ignoreErrors pattern to error message

[staticshock]

This resumes filtering opaque "Script error" messages caused by errors in cross-origin scripts.

Fixes #1075.

[kamilogorek]

@benvinegar this also resolves your concern from here #1057 (comment)

[kamilogorek]

Can we also change it so that testString doesn't become :message if it's undefined? per #1075 (comment)

[staticshock]

Yep! Addressed.

[kamilogorek]

This code will double-check the same string if type is not defined, but I think we can live with it.

Although an alternative would be something like this, which also do the job, but doesn't improve a readability really

if (!!this._globalOptions.ignoreErrors.test) {
  var testString = (type ? type + ': ' : '') + (message || '')
  if (this._globalOptions.ignoreErrors.test(message)) return
  if (testString !== message && this._globalOptions.ignoreErrors.test(testString)) return
}

I can live with the code we have now.

[kamilogorek]

@staticshock could you please add one quick test to make sure both scenarios work? https://github.com/getsentry/raven-js/blob/master/test/raven.test.js#L478-L490

Some of the scenarios where it should match:

input: 'CustomError: random 123 message'

/^CustomError: random 123 message$/
/^random 123 message$/
/^Custom Error/

'CustomError: random 123 message'
'123 message'
'CustomError'

[staticshock]

@kamilogorek how do you feel about this?

[kamilogorek]

@staticshock I think that in the end, initial version was more readable, so let's stick with it.
This double check issue I mentioned shouldn't be hit a lot of times anyway.
We can call it stringifiedError, errorString or something more descriptive than testString though :P

if (
  !!this._globalOptions.ignoreErrors.test && (
  this._globalOptions.ignoreErrors.test(message) ||
  this._globalOptions.ignoreErrors.test(stringifiedError))
)

Other then this all looks good! Thanks for updating tests :)

[staticshock]

✅

[kamilogorek]

Thanks! :)