feat: Include exception type in igoreErrors test

getsentry · Sep 27, 2017 · 7dc7ce6 · 7dc7ce6
1 parent b28db84
commit 7dc7ce6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/raven.js b/src/raven.js
@@ -1420,14 +1420,16 @@ Raven.prototype = {
   },
 
   _processException: function(type, message, fileurl, lineno, frames, options) {
-    var stacktrace;
+    type = type || '';
+    message = message || '';
+
     if (
       !!this._globalOptions.ignoreErrors.test &&
-      this._globalOptions.ignoreErrors.test(message)
+      this._globalOptions.ignoreErrors.test(type + ': ' + message)
     )
       return;
 
-    message += '';
+    var stacktrace;
 
     if (frames && frames.length) {
       fileurl = frames[0].filename || fileurl;

diff --git a/test/raven.test.js b/test/raven.test.js
@@ -478,11 +478,13 @@ describe('globals', function() {
     it('should respect `ignoreErrors`', function() {
       this.sinon.stub(Raven, '_send');
 
-      Raven._globalOptions.ignoreErrors = joinRegExp(['e1', 'e2']);
+      Raven._globalOptions.ignoreErrors = joinRegExp(['e1', 'e2', 'CustomError']);
       Raven._processException('Error', 'e1', 'http://example.com', []);
       assert.isFalse(Raven._send.called);
       Raven._processException('Error', 'e2', 'http://example.com', []);
       assert.isFalse(Raven._send.called);
+      Raven._processException('CustomError', 'e3', 'http://example.com', []);
+      assert.isFalse(Raven._send.called);
       Raven._processException('Error', 'error', 'http://example.com', []);
       assert.isTrue(Raven._send.calledOnce);
     });