Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix SentrySwiftUI pod publish #2624

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

brustolin
Copy link
Contributor

I couldn't find out whether this is a feature or a bug, but in order to be able to publish SentrySwiftUI it need to have the same version of the other podspecs in the repo.

We can go forward with this approach (fine by me), or we can open a cocoapod github issue to find out if this is a bug or intended behaviour.

#skip-changelog

@philipphofmann
Copy link
Member

We can do that, but we must be clear in https://github.com/getsentry/sentry-cocoa/blob/main/Sources/SentrySwiftUI/SentryTracedView.swift that it's still experimental.

@philipphofmann
Copy link
Member

Please also add a note to our internal develop-docs why we bumped it to 8.0.0.

@github-actions
Copy link

github-actions bot commented Jan 18, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.12 ms 1256.28 ms 26.16 ms
Size 20.76 KiB 414.45 KiB 393.69 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b6ba04e 1217.45 ms 1248.92 ms 31.47 ms
feba2be 1246.67 ms 1254.64 ms 7.97 ms
443723a 1205.24 ms 1220.52 ms 15.28 ms
b6ba04e 1230.48 ms 1253.20 ms 22.72 ms
c6504da 1232.06 ms 1243.28 ms 11.22 ms
621ba9b 1190.66 ms 1230.84 ms 40.18 ms
56ec5d0 1236.65 ms 1261.90 ms 25.25 ms
3a31fc9 1237.35 ms 1249.02 ms 11.67 ms
7c5d161 1224.38 ms 1249.66 ms 25.28 ms
3f1be0f 1208.12 ms 1225.72 ms 17.60 ms

App size

Revision Plain With Sentry Diff
b6ba04e 20.76 KiB 414.45 KiB 393.69 KiB
feba2be 20.76 KiB 414.45 KiB 393.69 KiB
443723a 20.76 KiB 414.44 KiB 393.68 KiB
b6ba04e 20.76 KiB 414.44 KiB 393.68 KiB
c6504da 20.76 KiB 414.44 KiB 393.69 KiB
621ba9b 20.76 KiB 414.45 KiB 393.69 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.69 KiB
3a31fc9 20.76 KiB 414.45 KiB 393.69 KiB
7c5d161 20.76 KiB 414.44 KiB 393.68 KiB
3f1be0f 20.76 KiB 414.44 KiB 393.69 KiB

Previous results on branch: chore/fix-swiftui-cocoa-publish

Startup times

Revision Plain With Sentry Diff
4372297 1206.16 ms 1220.82 ms 14.66 ms

App size

Revision Plain With Sentry Diff
4372297 20.76 KiB 414.44 KiB 393.68 KiB

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #2624 (5220dbb) into main (56ec5d0) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2624      +/-   ##
==========================================
- Coverage   79.82%   79.73%   -0.09%     
==========================================
  Files         243      243              
  Lines       22614    22626      +12     
  Branches    10010    10021      +11     
==========================================
- Hits        18051    18041      -10     
- Misses       4112     4134      +22     
  Partials      451      451              
Impacted Files Coverage Δ
Sources/Sentry/SentryProfilingLogging.mm 0.00% <0.00%> (-51.86%) ⬇️
Sources/Sentry/include/SentryMachLogging.hpp 58.82% <0.00%> (-17.65%) ⬇️
Sources/Sentry/include/SentryProfilingLogging.hpp 45.45% <0.00%> (-9.10%) ⬇️
Sources/Sentry/SentryMachLogging.cpp 0.00% <0.00%> (-3.02%) ⬇️
Sources/Sentry/SentryNetworkTracker.m 95.39% <0.00%> (+0.18%) ⬆️
Sources/Sentry/SentryFileManager.m 95.66% <0.00%> (+0.20%) ⬆️
Sources/Sentry/SentryTime.mm 63.15% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ec5d0...5220dbb. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that 🙏

Date: January 18th, 2023
Contributors: @brustolin and @philipphofmann

We release experimental SentrySwiftUI cocoa package with the version 8.0.0 because all podspecs file in a repo need to have the same version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks for that important entry.

@brustolin brustolin merged commit 4c00f8c into main Jan 19, 2023
@brustolin brustolin deleted the chore/fix-swiftui-cocoa-publish branch January 19, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants