Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix releasing SwiftUI with Cocoapods #2581

Closed
Tracked by #2572
philipphofmann opened this issue Jan 5, 2023 · 5 comments
Closed
Tracked by #2572

Fix releasing SwiftUI with Cocoapods #2581

philipphofmann opened this issue Jan 5, 2023 · 5 comments

Comments

@philipphofmann
Copy link
Member

Description

Releasing SwiftUI with Cocoapods through craft failed with

  STDOUT: pod: Updating spec repo `github.jparrowsec.cn-cocoapods`
  pod: Validating podspec
  pod:  -> SentrySwiftUI
 -> SentrySwiftUI (0.1.0)
  pod:     - ERROR | [SentrySwiftUI/Core] file patterns: The `source_files` pattern did not match any file.
  pod:
  pod: [!] The spec did not pass validation, due to 1 error.
  pod:

That's a bit weird as CI validates the podspec with pod lib lint

validate-SentrySwiftUI-podspec:
name: Validate SentrySwiftUI Podspec
runs-on: macos-12
strategy:
matrix:
platform: ['ios', 'macos', 'tvos', 'watchos']
steps:
- uses: actions/checkout@v3
- run: ./scripts/ci-select-xcode.sh
- name: Validate Podspec
run: pod lib lint --verbose --platforms=${{ matrix.platform }} SentrySwiftUI.podspec --include-podspecs=Sentry.podspec,SentryPrivate.podspec
shell: sh

Also the path seems to be fine

sp.source_files = "Sources/SentrySwiftUI/**/*.{swift,h,m}"

@brustolin
Copy link
Contributor

This is strange. There is nothing wrong with podspec, all tests and lints are passing.

@philipphofmann
Copy link
Member Author

philipphofmann commented Jan 9, 2023

Yeah, I also don't get it @brustolin. Do we need to do something special cause it's the initial release?

@brustolin
Copy link
Contributor

SentryPrivate initial release was very straightforward, so I dont think this is the problem.

@philipphofmann philipphofmann self-assigned this Jan 16, 2023
@philipphofmann philipphofmann moved this from Needs Discussion to In Progress in Mobile & Cross Platform SDK Jan 16, 2023
@philipphofmann philipphofmann added this to the 8.0.0 milestone Jan 16, 2023
@philipphofmann philipphofmann moved this from In Progress to Needs Discussion in Mobile & Cross Platform SDK Jan 16, 2023
@philipphofmann philipphofmann removed their assignment Jan 16, 2023
@philipphofmann philipphofmann removed this from the 8.0.0 milestone Jan 16, 2023
@philipphofmann
Copy link
Member Author

I can also reprocude this locally when running pod trunk push SentrySwiftUI.podspec --allow-warnings --verbose. I get

ERROR | [SentrySwiftUI/Core] file patterns: The `source_files` pattern did not match any file.

Maybe it's because we don't specify public_header_files in SentrySwiftUI.podspec, because if you don't, all headers are considered public. Futhermore, I noticed that

s.swift_versions = "5.0"

Is different from

s.swift_versions = "5.5"

@brustolin
Copy link
Contributor

solved with #2624

@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants