Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix SentrySwiftUI pod publish #2624

Merged
merged 3 commits into from
Jan 19, 2023
Merged

chore: Fix SentrySwiftUI pod publish #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec8882e
Update SentrySwiftUI.podspec
brustolin Jan 17, 2023
5a53afb
Update SentryTracedView.swift
brustolin Jan 18, 2023
5220dbb
Update README.md
brustolin Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions SentrySwiftUI.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "SentrySwiftUI"
s.version = "0.1.0"
s.version = "8.0.0"
s.summary = "Sentry client for SwiftUI"
s.homepage = "https://github.com/getsentry/sentry-cocoa"
s.license = "mit"
Expand All @@ -15,15 +15,9 @@ Pod::Spec.new do |s|
s.module_name = "SentrySwiftUI"
s.requires_arc = true
s.frameworks = 'Foundation', 'SwiftUI'
s.swift_versions = "5.0"
s.watchos.pod_target_xcconfig = {
'OTHER_LDFLAGS' => '$(inherited) -framework WatchKit'
}
s.swift_versions = "5.5"
s.watchos.framework = 'WatchKit'

s.default_subspecs = ['Core']

s.subspec 'Core' do |sp|
sp.source_files = "Sources/SentrySwiftUI/**/*.{swift,h,m}"
sp.dependency 'Sentry', "8.0.0"
end
s.source_files = "Sources/SentrySwiftUI/**/*.{swift,h,m}"
s.dependency 'Sentry', "8.0.0"
end
6 changes: 6 additions & 0 deletions Sources/SentrySwiftUI/SentryTracedView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import SwiftUI
import SentryInternal
#endif

///
/// This feature is EXPERIMENTAL.
///
/// A control to measure the performance of your views and send the result as a transaction to Sentry.io.
///
/// You create a transaction by wrapping your views with this.
Expand Down Expand Up @@ -69,6 +72,9 @@ public struct SentryTracedView<Content: View>: View {
}
}

///
/// This feature is EXPERIMENTAL.
///
@available(iOS 13, macOS 10.15, tvOS 13, watchOS 6.0, *)
public extension View {
func sentryTrace(_ transactionName: String? = nil) -> some View {
Expand Down
7 changes: 7 additions & 0 deletions develop-docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,3 +180,10 @@ Date: January 16th, 2023
Contributors: @kahest, @brustolin and @philipphofmann

With 8.0.0, we rename the default branch from `master` to `main`. We will keep the `master` branch for backwards compatibility for package managers pointing to the `master` branch.

## SentrySwiftUI version

Date: January 18th, 2023
Contributors: @brustolin and @philipphofmann

We release experimental SentrySwiftUI cocoa package with the version 8.0.0 because all podspecs file in a repo need to have the same version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks for that important entry.