Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEANUP: Deprecation of multiprocess (since Oct 2020) #546

Closed
74 of 100 tasks
HenrikBengtsson opened this issue Sep 25, 2021 · 7 comments
Closed
74 of 100 tasks

CLEANUP: Deprecation of multiprocess (since Oct 2020) #546

HenrikBengtsson opened this issue Sep 25, 2021 · 7 comments
Milestone

Comments

@HenrikBengtsson
Copy link
Collaborator

HenrikBengtsson commented Sep 25, 2021

Packages on CRAN and Bioconductor that use 'multiprocess'

Last updated: 2023-03-21

Currently, multiprocess is defunct, but still exists. When multiprocess is removed in a later version, it will break 3 CRAN packages (and zero Bioconductor packages):

If you see this and are a maintainer of one of the above packages, please replace multiprocess with multisession. The multiprocess backend is defunct as of future 1.32.0 (2023-03-07), i.e. give an error if used.

Additional non-CRAN, non-Bioconductor packages

Completed

Last updated 2023-03-21.

Packages that fail checks because 'multiprocess' is now defunct

future 1.32.0 is on CRAN as of 2023-03-07. This broke 3 CRAN packages and 1 Bioconductor package.

Resolved

Moot, because removed from CRAN or Bioconductor (last updated 2022-06-02)

@HenrikBengtsson
Copy link
Collaborator Author

The next step in deprecating 'multiprocess' could be to make it become the same as 'sequential' regardless of argument workers. This will hopefully lead to more developers to update their code sooner.

@HenrikBengtsson HenrikBengtsson pinned this issue Jun 2, 2022
@zeehio
Copy link

zeehio commented Sep 15, 2022

You can remove AlpsNMR from this list, since I backported the deprecation fix to the release branch (and it's released already)

@HenrikBengtsson
Copy link
Collaborator Author

HenrikBengtsson commented Sep 24, 2022

Starting with next release of future (>= 1.28.0-9001), there will be one deprecation warning produced per 'multiprocess' future created. This may be very noisy, but that's on purpose. For example,

> library(future)
> plan(multiprocess)
Warning message:
Strategy 'multiprocess' is deprecated in future (>= 1.20.0) [2020-10-30]. Instead, explicitly specify either 'multisession' (recommended) or 'multicore'. In the current R session, 'multiprocess' equals 'multicore'. 

> y <- future.apply::future_lapply(1:3, FUN = sqrt)
Warning messages:
1: Detected creation of a 'multiprocess' future. Strategy 'multiprocess' is deprecated in future (>= 1.20.0) [2020-10-30]. Instead, explicitly specify either 'multisession' (recommended) or 'multicore'. In the current R session, 'multiprocess' equals 'multicore'. 
2: Detected creation of a 'multiprocess' future. Strategy 'multiprocess' is deprecated in future (>= 1.20.0) [2020-10-30]. Instead, explicitly specify either 'multisession' (recommended) or 'multicore'. In the current R session, 'multiprocess' equals 'multicore'. 
3: Detected creation of a 'multiprocess' future. Strategy 'multiprocess' is deprecated in future (>= 1.20.0) [2020-10-30]. Instead, explicitly specify either 'multisession' (recommended) or 'multicore'. In the current R session, 'multiprocess' equals 'multicore'. 
> 

@HenrikBengtsson HenrikBengtsson changed the title CLEANUP: Deprecating multiprocess CLEANUP: Deprecation of multiprocess (since Oct 2020) Oct 20, 2022
@HenrikBengtsson
Copy link
Collaborator Author

UPDATE 2023-01-17: Next step is to turn 'multiprocess' into 'sequential' processing; still with those warnings

HenrikBengtsson added a commit that referenced this issue Jan 17, 2023
…ntial); same for multiprocess() -> sequential() [#546]
@HenrikBengtsson
Copy link
Collaborator Author

I've made 'multiprocess' defunct when running interactive mode, while keeping it deprecated in batch mode (e.g. R CMD check) for a tad longer;

  • Deprecated plan(multiprocess, ...) is now defunct when running in interactive mode. The next step is to make it defunct also when running in batch mode.

@HenrikBengtsson
Copy link
Collaborator Author

I've decided to make multiprocess defunct in the next release, which I'll submit to CRAN today or tomorrow.

HenrikBengtsson added a commit that referenced this issue Mar 6, 2023
…are four packages failing as expected [ci skip] [#546]
@HenrikBengtsson HenrikBengtsson added this to the Next release milestone Mar 6, 2023
@HenrikBengtsson
Copy link
Collaborator Author

future 1.32.0 is on CRAN, where 'multiprocess' is now defunct. The next step will be to remove multiprocess from the API. When multiprocess is removed in a later version, it will break 3 CRAN packages (and zero Bioconductor packages):

I'm gonna close this issue and deal with the above at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants