Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTICE: plan(multiprocess) of future is deprecated #2

Open
Tracked by #546
HenrikBengtsson opened this issue Oct 19, 2021 · 2 comments
Open
Tracked by #546

NOTICE: plan(multiprocess) of future is deprecated #2

HenrikBengtsson opened this issue Oct 19, 2021 · 2 comments

Comments

@HenrikBengtsson
Copy link

HenrikBengtsson commented Oct 19, 2021

Hi.

This is a friendly reminder that plan(multiprocess) of the future package is deprecated since future 1.20.0 (2020-11-03). It will eventually become defunct and removed. The background for this can be found in futureverse/future#420.

Your alookr package relies on multiprocess, cf. https://github.com/choonghyunryu/alookr/search?q=multiprocess.

Please migrate your code to the platform-independent plan(multisession) or the Linux/macOS-specific plan(multicore). If you want to emulate what multiprocess does, you can do something like:

  if (parallelly::supportsMulticore()) {
    oplan <- plan(multicore)
  } else {
    oplan <- plan(multisession)
  }
  on.exit(plan(oplan))

BTW, if you don't already do so, please make sure to undo any plan() you set in your code, as illustrated by the above example. This is needed to guarantee that calling your code won't override settings that the user has set previously. You can read about this in https://future.futureverse.org/reference/plan.html#for-package-developers.

Thank you!

Henrik
(maintainer of the future package)

@HenrikBengtsson
Copy link
Author

I see you missed fixing this with your most recent CRAN release on 2022-05-25. Please note that your package will fail R CMD check when the 'multiprocess' is made defunct in future. I would appreciate if you could fix this in your package, because it would save me and the CRAN Team having to explain why reverse package break. Thank you.

@choonghyunryu
Copy link
Owner

choonghyunryu commented Jun 7, 2022

@HenrikBengtsson

Thanks for your notice.
I will modify the code to solve the issue.

And thank you for developing future. It is very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants