Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CRAN issues #309

Merged
merged 17 commits into from
Sep 22, 2022
Merged

fix CRAN issues #309

merged 17 commits into from
Sep 22, 2022

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 14, 2022

This picks out the changes in #308 relating to fixing of CRAN issues, and eliminates all remaining WARNINGS. This now passes all checks on winbuilder and rhub.

I'd suggest to submit this as version 1.3.3 now and integrate the new features in #308 (and/or #305) towards a later 1.3.4 release.

@sbfnk sbfnk requested a review from seabbs September 14, 2022 11:23
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in the main. There are a few issues that I think may slip through the cran check but still need fixing but think probably best to merge and fix as a follow up.

R/estimate_secondary.R Show resolved Hide resolved
tests/testthat/test-stan-rt.R Show resolved Hide resolved
@seabbs seabbs merged commit 59af7c1 into master Sep 22, 2022
@seabbs seabbs deleted the sa-fix-cran-issues branch September 22, 2022 20:09
sbfnk added a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants