-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more flexibility with delays #305
Conversation
See #308 for an alternative approach where delays are first estimated in R vs in model. This should be more efficient in theory but is incomplete. |
Precomputing the PMFs is of course a good idea to improve performance. This now contains the changes from #311 and #312 but implements the precomputation in the Benefits compared to the approach in #312 are that it avoids bleeding/duplication of model code into R and supports a mixture of fixed and variable delays. Downside is that it adds stan code and thus makes the stan model harder to read. Passes checks locally but needs some more thorough checking that it hasn't introduced a bug in the model itself. Also the indexing of generation time and delay PMF needs review - I think as implemented it bases the discretised generation times at 1 and delays/truncation at 0. |
This in principle looks good though a little confused where everything is coming from. Did this draw code from the convolve_pmf branch or roll it's own implementation. If it's own I need to get my head around if it's handling convolving pmts correctly. Code from convolve_pmf for reference. |
It includes the improved discrete convolution from #311 - not sure how that relates to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was just trying to get more familiar with EpiNow2 and the current development and ended up making some comments 🙈
partly reverts changes in 6532571
4668ad7
to
7c6bfa3
Compare
65ade60
to
0ede0b4
Compare
This adds support for
as well as unit tests for these.
It is based on #304 but separated out for clarity.