Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default for zarr_dir #1990

Merged
merged 27 commits into from
Nov 4, 2024
Merged

Set a default for zarr_dir #1990

merged 27 commits into from
Nov 4, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Oct 30, 2024

closes #1934
closes #1986
closes #1987

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.
  • I addressed Set a default for "Zarr dir" #1934 (comment) ("we can accept the edge-case of mistakenly reusing folders in sqlite then until we deprecate sqlite.")

@ychiucco ychiucco linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 30, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.5 11.0 0.95 0.6 0.6
power 405.0 402.3 1.01 366.2 366.2
dataset 153.0 149.3 1.02 134.0 134.0
project 49.4 47.4 1.04 47.2 47.2
job 28.2 27.2 1.04 32.4 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.2 6.6 1.09 2.2 2.2
power 142.8 141.4 1.01 652.0 652.0
dataset 141.7 141.5 1.00 904.8 904.8
project 51.4 49.3 1.04 283.7 283.7
job 38.8 38.4 1.01 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.5 7.8 1.09 0.1 0.1
power 7.9 7.8 1.01 0.1 0.1
dataset 7.8 7.7 1.01 0.1 0.1
project 9.9 9.6 1.03 2.3 2.3
job 7.7 7.6 1.01 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.4 6.3 1.02 0.8 0.8
power 6.5 6.2 1.05 0.8 0.8
dataset 6.7 6.5 1.03 0.8 0.8
project 6.3 6.2 1.02 0.8 0.8
job 6.2 6.4 0.97 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.5 7.5 1.00 1.4 1.4
power 7.6 7.3 1.04 1.4 1.4
dataset 7.6 7.4 1.03 1.4 1.4
project 7.5 7.3 1.03 1.4 1.4
job 7.6 7.4 1.03 1.4 1.4

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.6 11.8 1.07 0.8 0.8
power 26.7 26.5 1.01 29.1 29.1
dataset 20.5 19.8 1.04 16.7 16.7
project 26.7 23.1 1.16 21.0 21.0
job 12.2 11.4 1.07 0.8 0.8

POST /api/v2/project/3/dataset/408/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 156.2 151.1 1.03 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.2 5.2 1.00 0.2 0.2
power 5.0 5.0 1.00 0.2 0.2
dataset 5.1 4.8 1.06 0.2 0.2
project 5.0 4.8 1.04 0.2 0.2
job 5.0 4.9 1.02 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 263.4 263.2 1.00 0.2 0.2

Copy link

github-actions bot commented Oct 31, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/models
  user_settings.py
  fractal_server/app/routes/api/v2
  dataset.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/app/schemas
  user_settings.py
  fractal_server/app/schemas/v2
  dataset.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco requested a review from tcompa November 4, 2024 09:30
@tcompa
Copy link
Collaborator

tcompa commented Nov 4, 2024

Is #1987 covered here?

@tcompa tcompa merged commit 553d9af into main Nov 4, 2024
19 checks passed
@tcompa tcompa deleted the 1934-set-a-default-for-zarr-dir branch November 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants