-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a default for "Zarr dir" #1934
Comments
I can definitely see the use for this feature (which probably would live frontend-side rather than here - I'm now transferring the issue). We'd still need to define it a bit better:
Once we have these or similar questions defined, we can come up with a "hint". Additional details:
Several attributes are stable only in practice but not immutable by design: user/usergroup associations, usergroup paths, dataset names. If we aim at guaranteeing that these folders won't change, then we'll need to introduce an appropriate attribute like |
(keeping the issue backend-side in case we want to introduce a new database column in user settings, otherwise I think it will be handled client-side) |
I'm a big fan of adding something like this when we have a good default we know for users. While direct access to pick a directory is harder and will take a while to get to, this we can do earlier on.
That would be their Vizarr allowed base directory. Maybe we should consider renaming it to remove the Vizarr part, because we may use it as a default base path, and we may use it to stream data to napari eventually :) What is it called atm @tcompa ? It's shown as "Viewer paths" in the group management Re what our default should be: Things to consider:
We may only do that for the Science Cluster or come up with a way that would also work for other deployments. For UZH Pelkmans lab: FMI Liberali lab: Where the base path is the same for all users |
Very good questions Tommaso!
I'd say their first group
0 paths => no default shown (or maybe next group checked??)
Great question! Maybe this would be a case for where the username starts to become relevant
That seems fine to me. We're not forcing data to go there, we just provide a default. They can put it anywhere or change the dataset name later without changing the paths. Re hint vs default: If we can make it work well enough, I'd strongly prefer a default
That's an interesting idea as well to avoid a lot of heuristics above and make it work for different deployments. |
An additional detail here: We cannot naively rely on the dataset ID, since this is only known after the dataset is created.
I don't have a clear solution in mind right now - TBD |
A, good catch! True, that makes it trickier. Let's discuss at the Monday call whether we find a good direction for this |
This is something we can consider from my perspective. The result is: Setting a zarr_dir becomes optional, because the server will have a way to create one for you if you did not do it |
Discussion resultsReusing IDs: Not intended to happen => @tcompa will double check Goal: Users do not need to specify a zarr_dir by default. If they don't set one, Fractal creates it. It would get put into this folder:
What would Science Cluster/shares/project_share/username Pelkmans lab/data/active/slurm_user Liberali lab/path/to/gliberal/Users/slurm_user Open questions:
|
fractal-analytics-platform/fractal-vizarr-viewer#44
|
cc @jluethi
@ychiucco checked this, and it's only true with postgres. With sqlite, IDs of deleted objects can be re-used (see #1991), which could lead to duplicate folders. We could not rapidly find a way to change the sqlite configuration. The way we are proceeding for the moment is to just disable this option on sqlite instances. When using sqlite, you would only be able to create a dataset if you specify For the record, this change comes together with writing tests that depend on the specific database that is being used. And none of the two changes adds any value our to active (postgres-based) instances. |
Thanks for checking. Another strong reason to drop sqlite then. If this is too much effort to write for sqlite, we can accept the edge-case of mistakenly reusing folders in sqlite then until we deprecate sqlite. |
Since the user groups have a project directory assigned, setting a reasonable default when people create a dataset would be great.

Something like this:
This would be great because many users found this very cumbersome to fill.
Some ideas for default values:
I don't have any strong opinions on them, but it would be good if we picked something unlikely to change.
@tcompa @jluethi
The text was updated successfully, but these errors were encountered: