Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review missing ID autoincrement for sqlite #1991

Closed
tcompa opened this issue Oct 30, 2024 · 4 comments
Closed

Review missing ID autoincrement for sqlite #1991

tcompa opened this issue Oct 30, 2024 · 4 comments
Assignees
Labels

Comments

@tcompa
Copy link
Collaborator

tcompa commented Oct 30, 2024

As part of #1934, we need dataset IDs to be unique, even if a dataset is removed.
@ychiucco wrote a test for it (in #1990), which is OK on postgres but fails on sqlite.

Relevant refs:

@ychiucco
Copy link
Collaborator

We've tried

class DatasetV2(SQLModel, table=True):

    id: Optional[int] = Field(
        default=None,
        primary_key=True,
        sa_column_kwargs={'autoincrement': True}
    )

but nothing changed

@tcompa
Copy link
Collaborator Author

tcompa commented Oct 30, 2024

Also see #1260

@tcompa tcompa changed the title Fix missing ID autoincrement for sqlite Review missing ID autoincrement for sqlite Nov 4, 2024
@tcompa
Copy link
Collaborator Author

tcompa commented Nov 6, 2024

Closed with #1990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants