Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include user_settings.project_dir in list of allowed paths, on top of usergroup.viewer_paths #44

Closed
ychiucco opened this issue Oct 30, 2024 · 2 comments · Fixed by #47
Closed

Comments

@ychiucco
Copy link

ref fractal-analytics-platform/fractal-server#1934
ref fractal-analytics-platform/fractal-server#1986

from fractal-analytics-platform/fractal-server#1934 (comment)

How does it match with the `user_group.viewer_paths`?
These are per user group. Do we add the `user.project_dir` to the things a user has access to?
Some potential complexities in whether users would have access to all their `zarr_dir`s
@jluethi
Copy link

jluethi commented Nov 1, 2024

Let's be careful here that we add the admin-set user.project_dir, not all dataset.zarr_dir. Because a user could set those to anything and thus gain access to data they shouldn't if we use them in access management

@tcompa
Copy link
Collaborator

tcompa commented Nov 4, 2024

Let's be careful here that we add the admin-set user.project_dir, not all dataset.zarr_dir. Because a user could set those to anything and thus gain access to data they shouldn't if we use them in access management

Agreed.
It a low risk, because fractal-vizarr-viewer should never make any call to /api/ endpoints (like the ones that would list the dataset attributes), but only to /auth (i.e. the ones with info about users, usergroups, settings, ..).

@tcompa tcompa changed the title PLACEHOLDER: optional zarr_dir Include user_settings.project_dir in list of allowed paths, on top of usergroup.viewer_paths Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants