chore: check warnings and errors from gulp lint

[DanielRuf]

Description

Check warnings and errors from gulp lint.

[aorinevo]

Hi @DanielRuf, is the scope of work for this issue to resolve all warnings and errors from gulp lint?

[ncoden]

Hi @DanielRuf. I had some time so I investigated on why the Sass linting errors were not shown in the build task. See #11454

[pebutler3]

@joeworkman is it cool if I start tackling these errors?

[joeworkman]

@pebutler3 That would be amazing! I am hosting a conference this weekend. So I have had my head in the sand preparing for that.

[pebutler3]

How does everyone feel about disabling this "no-extra-parens": 1, in .eslintrc ?

I bring this up because this rule is being called out in quite a few math related scenarios where I believe the code is more readable with the parens.

[DanielRuf]

How does everyone feel about disabling this "no-extra-parens": 1, in .eslintrc ?

I bring this up because this rule is being called out in quite a few math related scenarios where I believe the code is more readable with the parens.

We should create a new issue. The original issue was about the sasslint errors.

For eslintrc and other stuff, please open new issues.

[joeworkman]

@pebutler3 I created a new issue.

#12299