chore: use split gulp tasks instead of the unsuitable "finish" event #11452 #11454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to build task Changes: - Remove broken Sass linting from the `sass:foundation` task. The `finish` gulp event is an stream internal event and is not suitable to chain tasks. - Add `lint:graceful`, `lint:graceful:sass` and `lint:graceful:javascript` to check for linting errors without throwing errors and breaking the chain of tasks. - Call `lint:graceful` on the build task. For now, there is too much linting issues to display them at each Sass/Javascript compilation.
The `finish` gulp event is an stream internal event and is not suitable to chain tasks. Changes: - Move pages building to the `docs:pages` and `docs:pages:all` subtasks - Move search entries building to the `docs:search` subtask
…zer:clean` The `finish` gulp event is an stream internal event and is not suitable to chain tasks. Changes: - Move the custom ZIP file generation to the `customizer:zip` task - Move the cleaning of the customizer build directory to `customizer:clean` task
ncoden
changed the title
|
@DanielRuf 👋 Would you have some time to review this ? |
ncoden
added a commit
that referenced
this pull request
Aug 25, 2018
….5.0 6c45b45 fix: remove broken Sass linting from Sass compilation task and move it to build task 80c6def refactor: split the docs build task to `docs:pages` and `docs:search` 6b12883 refactor: move the customizer ZIPing to `customizer:zip` and `customizer:clean` Signed-off-by: Nicolas Coden <[email protected]>
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Sep 4, 2018
Documentation styles uses the SCSS mixins/functions, so they must be recompiled when the SCSS change. Introduced in foundation#11454
This was referenced Sep 4, 2018
Merged
noahheck
pushed a commit
to noahheck/foundation-sites
that referenced
this pull request
Jan 28, 2019
…452 for v6.5.0 6c45b45 fix: remove broken Sass linting from Sass compilation task and move it to build task 80c6def refactor: split the docs build task to `docs:pages` and `docs:search` 6b12883 refactor: move the customizer ZIPing to `customizer:zip` and `customizer:clean` Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
finishGulp event is an stream internal event and is not suitable to chain tasks. This pull request remove the dependency on this event from all Gulp tasks and prefer the usage of nano tasks withgulp.series.Changes
sass:foundationsass:foundationtask. Thefinishgulp event is an stream internal event and is not suitable to chain tasks.lint:graceful,lint:graceful:sassandlint:graceful:javascriptto check for linting errors without throwing errors and breaking the chain of tasks.lint:gracefulon thebuildtask. For now, there is too much linting issues to display them at each Sass/Javascript compilation.docsdocs:pagesanddocs:pages:allsubtasksdocs:searchsubtaskcustomizercustomizer:ziptaskcustomizer:cleantaskTypes of changes
functionality to change)
Checklist (all required):
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).