Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: gulp eslint fix #11889

Closed
wants to merge 1 commit into from
Closed

chore: gulp eslint fix #11889

wants to merge 1 commit into from

Conversation

ydegtyar
Copy link

Description

Fix a bunch of lint warnings in scss files. Mostly it's property order, indentations, trailing semicolons, leading zeros, spaces and newlines.

  • Sort properties
  • Rename scss variables with proper convention.
  • Move mixins before declarations
  • Delete empty declaration blocks

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf DanielRuf requested a review from SassNinja October 25, 2019 23:17
@DanielRuf DanielRuf added the scss label Oct 25, 2019
@DanielRuf DanielRuf added this to the 6.6.0 milestone Oct 25, 2019
@DanielRuf
Copy link
Contributor

Hi @ydegtyar,

thanks for your contribution. We will check these.

But please use a new branch instead of adding your changes on top of develop.

@weekly-digest weekly-digest bot mentioned this pull request Oct 27, 2019
Closed
@DanielRuf DanielRuf changed the title Chore: gulp eslint fix chore: gulp eslint fix Oct 29, 2019
@weekly-digest weekly-digest bot mentioned this pull request Nov 3, 2019
Closed
DanielRuf
DanielRuf suggested changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my last comment.

@SassNinja
Copy link
Contributor

@ydegtyar have you understood what @DanielRuf means?

Your PR is made from the develop branch (ydegtyar:develop) what is against our Contributing Guidelines

Please do the changes in a dedicated branch (e.g. ydegtyar:chore/gulp-eslint-fix) and submit a new PR.

You can cherry-pick your changes there to avoid doing all the work again.

@SassNinja SassNinja closed this Nov 6, 2019
@SassNinja SassNinja removed this from the 6.6.0 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf requested changes

@SassNinja SassNinja Awaiting requested review from SassNinja

Assignees
No one assigned
Labels
close:invalid Hacktoberfest scss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: check warnings and errors from gulp lint
3 participants
@ydegtyar @DanielRuf @SassNinja