Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release v1.13.0 #6853

Merged
merged 22 commits into from
Feb 20, 2020
Merged

chore: Release v1.13.0 #6853

merged 22 commits into from
Feb 20, 2020

Conversation

iamareebjamal
Copy link
Member

No description provided.

iamareebjamal and others added 21 commits February 2, 2020 21:09
chore: Release v1.12.0
Since we are directly depending on werkzeug, it should
be tracked in requirements file so that transitive upgrade
does not break the project
Updates the requirements on [humanize](https://github.com/jmoiron/humanize) to permit the latest version.
- [Release notes](https://github.com/jmoiron/humanize/releases)
- [Commits](jmoiron/humanize@0.5.1...1.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@auto-label auto-label bot added the chore label Feb 20, 2020
with self.app.test_request_context():
TicketFeesFactory(service_fee=10.23, maximum_fee=11)

test_event = EventFactoryBasic(state='published')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@@ -33,7 +33,9 @@ def match_discount_quantity(discount_code, tickets=None, ticket_holders=None):
qty = 0
ticket_ids = [ticket.id for ticket in discount_code.tickets]
old_holders = get_count(
TicketHolder.query.filter(TicketHolder.ticket_id.in_(ticket_ids))
TicketHolder.query.filter(
TicketHolder.ticket_id.in_(ticket_ids) # pytype: disable=attribute-error

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

+ u"<br/> <a href='{pdf_url}'>Click here</a> to view/download your ticket."
+ u"<br/> Your tickets & invoice have been enclosed."
u"<br><br>You can also download your tickets in <b>My Tickets</b> section."
u"<br/>Login to manage the orders at <a href='{mytickets_url}' target='_blank'>{mytickets_url}</a> </em>"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (117 > 90 characters)

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
- Added 1
           

Complexity increasing per file
==============================
- app/api/helpers/utilities.py  1
- app/api/helpers/permission_manager.py  1
         

Complexity decreasing per file
==============================
+ app/models/helpers/versioning.py  -23
+ app/settings/__init__.py  -6
         

See the complete overview on Codacy

@@ -384,7 +385,7 @@ def import_event_json(task_handle, zip_path, creator_id):
except IOError:
db.session.delete(new_event)
db.session.commit()
raise NotFoundError('File %s missing in event zip' % item[0])
raise NotFoundError('file', 'File %s missing in event zip' % item[0])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #6853 into master will increase coverage by 0.7%.
The diff coverage is 52.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6853     +/-   ##
=========================================
+ Coverage    65.5%   66.21%   +0.7%     
=========================================
  Files         306      307      +1     
  Lines       15346    15298     -48     
=========================================
+ Hits        10052    10129     +77     
+ Misses       5294     5169    -125
Impacted Files Coverage Δ
app/api/helpers/mail.py 28.43% <ø> (ø) ⬆️
app/models/user.py 57.24% <ø> (ø) ⬆️
app/api/helpers/ticketing.py 16.8% <ø> (ø) ⬆️
app/api/helpers/system_mails.py 100% <ø> (ø) ⬆️
app/api/users.py 29.82% <ø> (ø) ⬆️
app/models/track.py 67.64% <ø> (ø) ⬆️
app/models/event.py 81.27% <0%> (+2.82%) ⬆️
app/api/helpers/tasks.py 17.36% <0%> (ø) ⬆️
app/api/helpers/utilities.py 68.65% <0%> (ø) ⬆️
app/views/healthcheck.py 43.33% <0%> (-1.67%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afce3b...25e6a09. Read the comment docs.

@niranjan94 niranjan94 temporarily deployed to opev February 20, 2020 08:31 Inactive
@@ -1,6 +1,6 @@
from flask import Blueprint, jsonify

SERVER_VERSION = '1.12.0'
SERVER_VERSION = '1.13.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@iamareebjamal iamareebjamal merged commit d08a143 into master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants