fix: Invoice emails errors fixed and integration test

[mrsaicharan1]

Fixes #6486

Short description of what this resolves:

The invoice emails which were supposed to be sent out every month would error out if a ticket fee wasn't sent in the admin section.

Changes proposed in this pull request:

• Handled the TicketFee Error
• Added integration test to test calculation
• Corrected Invoice Calculation Logic

[houndci-bot]

local variable 'test_ticket_holder' is assigned to but never used

[mrsaicharan1]

The event invoice is calculated as:
(number of tickets purchased over the last month x ticket_price x percentage_ticket_fee). This was being calculated prior to this as well but the net revenue(gross_revenue - event invoice) was being stored in the Event Invoice Model. Fixed that up as well.

[codecov]

Codecov Report

Merging #6804 into development will not change coverage.
The diff coverage is 97.95%.

@@             Coverage Diff              @@
##           development    #6804   +/-   ##
============================================
  Coverage        65.86%   65.86%           
============================================
  Files              307      307           
  Lines            15382    15382           
============================================
  Hits             10131    10131           
  Misses            5251     5251

Impacted Files	Coverage Δ
app/api/schema/events.py	91.47% <ø> (ø)	⬆️
app/factories/session.py	100% <ø> (ø)	⬆️
app/factories/role_invite.py	100% <ø> (ø)	⬆️
.../all/integration/api/helpers/test_csv_jobs_util.py	98.86% <ø> (ø)	⬆️
app/factories/attendee.py	100% <ø> (ø)	⬆️
app/factories/user_token_blacklist.py	100% <100%> (ø)	⬆️
app/models/role_invite.py	92.1% <100%> (ø)	⬆️
app/models/access_code.py	93.33% <100%> (ø)	⬆️
...all/integration/api/helpers/test_scheduled_jobs.py	100% <100%> (ø)	⬆️
app/api/server_version.py	83.33% <100%> (ø)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f124456...4d61720. Read the comment docs.

[iamareebjamal]

Not sure about this

[mrsaicharan1]

https://www.eventbrite.com/organizer/pricing/

[mrsaicharan1]

Considering the Absorb Fees option as of now. Pass fees onto attendees can be implemented as well as a part of the upcoming features.

[mrsaicharan1]

@diru1100 Hi, would be great if you could review the logic for this. Thanks!

[me-diru]

Hey, Eventbrite seems to calculate it in the same way. The only difference is that they add a fixed rate to the calculated amount too. 2% + 0.79$

[mrsaicharan1]

@iamareebjamal I think this should be good to go.

[mrsaicharan1]

If the invoice calculation is fine here, we can go ahead with the test over here #6820

[iamareebjamal]

Do you want to add the test here itself?

[mrsaicharan1]

I’ve added the test for the scheduled task here.

…

On Thu, 6 Feb 2020 at 12:42 PM, Areeb Jamal ***@***.***> wrote: Do you want to add the test here itself? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6804?email_source=notifications&email_token=AGAHUWZJXE64STENRITISSDRBOZ43A5CNFSM4KOSTZE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6FN2I#issuecomment-582768361>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGAHUW6ZWHM2AGHRI5VIRM3RBOZ43ANCNFSM4KOSTZEQ> .