fix: Removed inaccessible link & added user request info #6821
Conversation
mrsaicharan1
force-pushed
the
ticket-access
branch
from
e5bc037 to
f90e2f3
Compare
mrsaicharan1
force-pushed
the
ticket-access
branch
from
0a51b5e to
0accab2
Compare
|
Add a link to my tickets section |
| @@ -188,7 +188,8 @@ | |||
| 'message': ( | |||
| u"Hi, this is a confirmation mail of your tickets for the event {event_name}" | |||
| u"<br/>Your order has been processed successfully." | |||
| + u"<br/> <a href='{pdf_url}'>Click here</a> to view/download your ticket." | |||
There was a problem hiding this comment.
Can we also remove the pdf_url attribute from the api/mail.py in send mail attendee function?
There was a problem hiding this comment.
I'm not sure I understand. Could you point me to the permalink?
There was a problem hiding this comment.
html=MAILS[TICKET_PURCHASED]['message'].format(
pdf_url=holder.pdf_url,
event_name=order.event.name,
frontend_url=get_settings()['frontend_url'],
),pdf_url here can be removed after this change .
| + u"<br/> <a href='{pdf_url}'>Click here</a> to view/download your ticket." | ||
| + u"<br/> Your tickets & invoice have been enclosed." | ||
| u"<br><br>You can also download your tickets in <b>My Tickets</b> section." | ||
| u"<br/>Login to manage the orders at <a href='{mytickets_url}' target='_blank'>{mytickets_url}</a> </em>" |
There was a problem hiding this comment.
line too long (117 > 90 characters)
mrsaicharan1
force-pushed
the
ticket-access
branch
from
ee2fc56 to
379615e
Compare
Update app/api/helpers/mail.py Co-Authored-By: Areeb Jamal <[email protected]>
mrsaicharan1
force-pushed
the
ticket-access
branch
from
4b7a358 to
ba60701
Compare
|
travis seems to be failing because of this. |
|
That's a warning, not an error |
|
Oops. Meant by this. |
Codecov Report
@@ Coverage Diff @@
## development #6821 +/- ##
===============================================
+ Coverage 65.85% 65.86% +<.01%
===============================================
Files 307 307
Lines 15382 15382
===============================================
+ Hits 10130 10131 +1
+ Misses 5252 5251 -1
Continue to review full report at Codecov.
|
Fixes #6818
Short description of what this resolves: