Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage DSIG table presence #3398

Closed
khaledhosny opened this issue Aug 1, 2021 · 6 comments
Closed

Discourage DSIG table presence #3398

khaledhosny opened this issue Aug 1, 2021 · 6 comments
Assignees
Milestone

Comments

@khaledhosny
Copy link
Contributor

khaledhosny commented Aug 1, 2021

Observed behaviour

fontbakery issues a FAIL message for fonts without DSIG table (com.google.fonts/check/dsig).

Expected behaviour

Do nothing, don’t even issue a WARN or INFO, DSIG table is unused; MS Office used to require it to enable OpenType features for so-called simple scripts but does not do any more and not everyone is building such fonts.

Resources and exact process needed to replicate

Any font produced in the last millennium that did not add DSIG table to make fontbackery FAIL go away.

@simoncozens
Copy link
Collaborator

I remember rumours that MS Office Mac still does?

@chrissimpkins
Copy link
Member

#1845 (comment)

@davelab6
Copy link
Contributor

davelab6 commented Aug 5, 2021

Any font produced in the last millennium that did not add DSIG table to make fontbackery FAIL go away.

LOL

In fact, I think we should flip the check to WARN people if a DSIG is found at all, and tell them to remove it.

@davelab6
Copy link
Contributor

davelab6 commented Aug 5, 2021

This is relatively high severity because it is so annoying :)

@davelab6 davelab6 changed the title Stop requiring DSIG table Discourage DSIG table presence Aug 5, 2021
@felipesanches felipesanches added this to the 0.8.1 milestone Aug 5, 2021
@felipesanches
Copy link
Collaborator

The rationale in this check currently says:


Microsoft Office 2013 and below products expect fonts to have a digital signature declared in a DSIG table in order to implement OpenType features. The EOL date for Microsoft Office 2013 products is 4/11/2023. This issue does not impact Microsoft Office 2016 and above products.

This checks verifies that this signature is available in the font.

A fake signature is enough to address this issue. If needed, a dummy table can be added to the font with the gftools fix-dsig script available at https://github.com/googlefonts/gftools


I'm OK with changing the check to reflect a new policy of removing the table from all fonts even if there's still ~1,5 year until the EOL date for Office 2013. Sounds like a reasonable time to do so now.

@felipesanches
Copy link
Collaborator

For now, a WARN, but by November 2023 we should finally make this a FAIL.

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 5, 2021
on universal profile, check/required_tables
(issue fonttools#3398)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 5, 2021
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached.

OpenType profile: com.google.fonts/check/dsig
(issues fonttools#3398, fonttools#1845
and googlefonts/fontmake#431)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 5, 2021
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached.

OpenType profile: com.google.fonts/check/dsig
(issues fonttools#3398, fonttools#1845
and googlefonts/fontmake#431)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 5, 2021
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached.

OpenType profile: com.google.fonts/check/dsig
(issues fonttools#3398, fonttools#1845
and googlefonts/fontmake#431)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 5, 2021
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached.

OpenType profile: com.google.fonts/check/dsig
(issues fonttools#3398, fonttools#1845
and googlefonts/fontmake#431)
felipesanches added a commit that referenced this issue Aug 5, 2021
on universal profile, check/required_tables
(issue #3398)
felipesanches added a commit that referenced this issue Aug 5, 2021
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached.

OpenType profile: com.google.fonts/check/dsig
(issues #3398, #1845
and googlefonts/fontmake#431)
felipesanches added a commit to felipesanches/fontspector that referenced this issue Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants