-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discourage DSIG table presence #3398
Comments
I remember rumours that MS Office Mac still does? |
Any font produced in the last millennium that did not add LOL In fact, I think we should flip the check to WARN people if a DSIG is found at all, and tell them to remove it. |
This is relatively high severity because it is so annoying :) |
The rationale in this check currently says: Microsoft Office 2013 and below products expect fonts to have a digital signature declared in a DSIG table in order to implement OpenType features. The EOL date for Microsoft Office 2013 products is 4/11/2023. This issue does not impact Microsoft Office 2016 and above products. This checks verifies that this signature is available in the font. A fake signature is enough to address this issue. If needed, a dummy table can be added to the font with the I'm OK with changing the check to reflect a new policy of removing the table from all fonts even if there's still ~1,5 year until the EOL date for Office 2013. Sounds like a reasonable time to do so now. |
For now, a WARN, but by November 2023 we should finally make this a FAIL. |
on universal profile, check/required_tables (issue fonttools#3398)
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached. OpenType profile: com.google.fonts/check/dsig (issues fonttools#3398, fonttools#1845 and googlefonts/fontmake#431)
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached. OpenType profile: com.google.fonts/check/dsig (issues fonttools#3398, fonttools#1845 and googlefonts/fontmake#431)
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached. OpenType profile: com.google.fonts/check/dsig (issues fonttools#3398, fonttools#1845 and googlefonts/fontmake#431)
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached. OpenType profile: com.google.fonts/check/dsig (issues fonttools#3398, fonttools#1845 and googlefonts/fontmake#431)
on universal profile, check/required_tables (issue #3398)
We may make this a FAIL by November 2023 when the EOL date for MS Office 2013 is reached. OpenType profile: com.google.fonts/check/dsig (issues #3398, #1845 and googlefonts/fontmake#431)
"The font should not need a DSIG table anymore." Added to the OpenType profile. ported from https://github.com/fonttools/fontbakery/blob/33632eba19c5b8a9f75f4ce268db7dd7f987e44c/Lib/fontbakery/checks/opentype/dsig.py#L6-L39 (original proposal: fonttools/fontbakery#3398)
Observed behaviour
fontbakery issues a FAIL message for fonts without
DSIG
table (com.google.fonts/check/dsig
).Expected behaviour
Do nothing, don’t even issue a WARN or INFO,
DSIG
table is unused; MS Office used to require it to enable OpenType features for so-called simple scripts but does not do any more and not everyone is building such fonts.Resources and exact process needed to replicate
Any font produced in the last millennium that did not add
DSIG
table to make fontbackery FAIL go away.The text was updated successfully, but these errors were encountered: