Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adobefonts override on the DSIG check #3407

Closed
felipesanches opened this issue Aug 6, 2021 · 1 comment
Closed

Remove adobefonts override on the DSIG check #3407

felipesanches opened this issue Aug 6, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@felipesanches
Copy link
Collaborator

We have just updated the policy implemented on check/dsig to WARN users that they should remove the DSIG table (unless they're specially interested in still supporting OpenType features on fonts used on MS Office 2013).

See issue #3398 for more info.

This change in check behavior means the Adobe Fonts check override is not needed anymore (now it would actually be incorrect if kept unchanged):
Screenshot from 2021-08-06 04-44-26

@felipesanches felipesanches added this to the 0.8.1 milestone Aug 6, 2021
@felipesanches felipesanches self-assigned this Aug 6, 2021
@felipesanches
Copy link
Collaborator Author

@cjchapman FYI: I am removing that override on the adobefonts profile since the logic in the check implementation has flipped to suggest (with a WARN) the complete removal of the DSIG table instead of demanding (with a FAIL) the inclusion of a dummy signature.

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 6, 2021
Outdated since the original check implementation changed to actually suggest (with a WARN) the removal of any DSIG tables.
(issue fonttools#3407)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 6, 2021
Outdated since the original check implementation changed to actually suggest (with a WARN) the removal of any DSIG tables.
(issue fonttools#3407)
felipesanches added a commit that referenced this issue Aug 6, 2021
Outdated since the original check implementation changed to actually suggest (with a WARN) the removal of any DSIG tables.
(issue #3407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant