Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-dsig disappeared in v0.9.0 #564

Closed
rsms opened this issue May 22, 2022 · 3 comments
Closed

fix-dsig disappeared in v0.9.0 #564

rsms opened this issue May 22, 2022 · 3 comments

Comments

@rsms
Copy link

rsms commented May 22, 2022

Upgraded gftools today and my build broke as the "fix-dsig" subcommand disappeared in v0.9.0.

I've looked through the list of subcommands and part of the source code of v0.9x to see if it changed name, but it seems it was simply removed (the subcommand; the implementation code is still there in the lib dir.)

@m4rc1e
Copy link
Collaborator

m4rc1e commented May 23, 2022

We've stopped including dummy dsig tables in our fonts, fonttools/fontbakery#3398. I removed this script in, #501. Can readd it and include a deprecated message if that will help you? However, I suggest just ignoring this table completely.

@rsms
Copy link
Author

rsms commented May 23, 2022

Ah, thanks for the info. It was added to the Inter build process to satisfy Google Fonts, so I guess I can remove that step now :•)

@rsms rsms closed this as completed May 23, 2022
@ctrlcctrlv
Copy link

This should not have been closed without updating the documentation. This just caused a build failure for me in a font that was working months ago.

I recommend…

  • Removing reference to fix-dsig on https://github.com/googlefonts/gftools#tool-usage-examples (README.md).
  • Either:
    • Keeping around a help item for it (I don't know how to do this thus haven't opened PR) saying it's deprecated and to drop it from scripts
    • Adding it back, warning users Google no longer requires it but it remains as perhaps they want it …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants